Skip to content

OSDOCS-17917: OVE ISO preconfig#106670

Open
skopacz1 wants to merge 4 commits into
openshift:mainfrom
skopacz1:OSDOCS-17917
Open

OSDOCS-17917: OVE ISO preconfig#106670
skopacz1 wants to merge 4 commits into
openshift:mainfrom
skopacz1:OSDOCS-17917

Conversation

@skopacz1

@skopacz1 skopacz1 commented Feb 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

OSDOCS-17917

Version: 4.21+

This PR adds additional changes to the OVE install UI that will be added for a 4.21.z version of the ISO.

QE review:

  • QE has approved this change.

Previews:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 16, 2026
@openshift-ci-robot

openshift-ci-robot commented Feb 16, 2026 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown

@skopacz1: This pull request references OSDOCS-17917 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

OSDOCS-17917

Version: 4.21+

This PR adds additional changes to the OVE install UI that will be added for a 4.21.z version of the ISO.

QE review:

  • QE has approved this change.

Previews:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 16, 2026
skopacz1
skopacz1 commented Feb 16, 2026
View reviewed changes
Comment thread modules/installing-ove-console-final.adoc
@ocpdocs-previewbot

ocpdocs-previewbot commented Feb 16, 2026 •
edited
Loading

Copy link
Copy Markdown

🤖 Mon Mar 09 16:22:08 - Prow CI generated the docs preview:

https://106670--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_with_agent_based_installer/installing-ove.html

skopacz1
skopacz1 commented Feb 16, 2026
View reviewed changes
Comment thread modules/installing-ove-iso.adoc Outdated

.. Upload a SSH public key in the *SSH public key* field.

.. Select *Edit pull secret* and add a pull secret to the field that appears.

@skopacz1 skopacz1 Feb 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm aware there's discussion to remove this option entirely, so I am ready to delete this line if that will be removed in time for release.

It's also not optional right now (can't click "Next" without putting something in, and the UI doesn't give any hint that it's mandatory), so if it will have to stay then I need to rewrite this to indicate that.

@skopacz1 skopacz1 Feb 25, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of today, the conversation in the slack channel seems pretty confirmed that the pull secret field is going to be removed entirely from the UI. Is that correct?

@openshift-ci-robot

openshift-ci-robot commented Feb 16, 2026 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown

@skopacz1: This pull request references OSDOCS-17917 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

OSDOCS-17917

Version: 4.21+

This PR adds additional changes to the OVE install UI that will be added for a 4.21.z version of the ISO.

QE review:

  • QE has approved this change.

Previews:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

andfasano
andfasano reviewed Feb 17, 2026
View reviewed changes
Comment thread modules/installing-ove-console-final.adoc
However, at this stage, you must at least have enough available hosts to match the value you specified in the *Number of control plane nodes* field of the installation console's *Cluster details* page.
====

* You have created DNS records for the Kubernetes API (`api.<cluster_name>.<base_domain>` and `api-int.<cluster_name>.<base_domain>`).

@andfasano andfasano Feb 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're still looking over if we could drop the api-int requirement

andfasano
andfasano reviewed Feb 17, 2026
View reviewed changes
Comment thread modules/installing-ove-console-final.adoc Outdated
* You have created DNS records for the Kubernetes API (`api.<cluster_name>.<base_domain>` and `api-int.<cluster_name>.<base_domain>`).
For more information, see "Platform "none" DNS requirements".

* You have configured port 22623 to allow internal traffic between nodes.

@andfasano andfasano Feb 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* You have configured port 22623 to allow internal traffic between nodes.
* You have configured port 22625 to allow internal traffic between nodes.

(22623 is for MCS)

andfasano
andfasano reviewed Feb 17, 2026
View reviewed changes
Comment thread modules/installing-ove-iso.adoc
@openshift-ci openshift-ci Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 24, 2026
@openshift-ci

openshift-ci Bot commented Mar 9, 2026

Copy link
Copy Markdown

@skopacz1: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mzasepaRedHat

mzasepaRedHat commented Apr 9, 2026

Copy link
Copy Markdown

@skopacz1 see a summary with my comments/suggestions:

  1. Downloading ISO section
    1.1. Is "above-the-sea" and "below-the-sea" integration aligned with this PR?
    1.2. How should we treat "Static Networking" as an optional or conditional configuration?
    1.3. (GENERAL COMMENT): Installation with ISO supports platform:baremetal and none. Reading the documentation, I had an impression that only platform:baremetal is supported.
  2. Mounting the ISO and booting the rendezvous node section (not updated in this PR)
    2.1. Should it be updated because of "above-the-sea" and "below-the-sea" integration? E.g., Rendezvous node IP can be provided in "above-the-sea" and should be visible and a user should be able to modify it.
  3. Booting the remaining cluster hosts section (not updated in this PR)
    3.1. Similar comment to the one in 2.1 on the level of remaining cluster hosts
  4. Completing cluster configuration and initiating the installation section
    4.1. What do you think about adding a statement that Networking can be provided by "above-the-sea" and it can be modified.
  5. Other comments:
    5.1. What do you think about adding link to the new document added in PR OSDOCS-17918: configuring external registry #107199?

CC: @andfasano

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@andfasano andfasano andfasano left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@skopacz1 @openshift-ci-robot @ocpdocs-previewbot @mzasepaRedHat @andfasano