Skip to content

update the golang version#89

Open
weshayutin wants to merge 1 commit into
openshift:oadp-devfrom
weshayutin:golang_version
Open

update the golang version#89
weshayutin wants to merge 1 commit into
openshift:oadp-devfrom
weshayutin:golang_version

Conversation

@weshayutin

@weshayutin weshayutin commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

update for cve's

Summary by CodeRabbit

  • Chores
    • Updated Go toolchain version from 1.25.0 to 1.25.8
    • Simplified Go module version directives

Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
@openshift-ci openshift-ci Bot requested review from mpryc and mrnold April 17, 2026 17:50
@openshift-ci

openshift-ci Bot commented Apr 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@weshayutin

Copy link
Copy Markdown
Contributor Author

/cherry-pick oadp-1.6

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2026
@openshift-cherrypick-robot

Copy link
Copy Markdown
Contributor

@weshayutin: once the present PR merges, I will cherry-pick it on top of oadp-1.6 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick oadp-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai

coderabbitai Bot commented Apr 17, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: da1655eb-8843-4839-9668-a43178b8d08e

📥 Commits

Reviewing files that changed from the base of the PR and between b9adb9e and 9007b7b.

📒 Files selected for processing (1)
  • go.mod

Walkthrough

The Go version requirement in go.mod was updated from version 1.25.0 to 1.25.8, and the explicit toolchain directive was removed. This consolidates the Go version specification into a single declaration.

Changes

Cohort / File(s) Summary
Go Module Version Update
go.mod
Updated Go version directive from go 1.25.0 to go 1.25.8 and removed the explicit toolchain go1.25.8 directive, consolidating version management.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 10
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'update the golang version' directly describes the main change in the changeset, which updates Go version from 1.25.0 to 1.25.8 and removes the toolchain directive.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed The PR only modifies go.mod to update Go version from 1.25.0 to 1.25.8 with no test-related changes.
Test Structure And Quality ✅ Passed PR modifies only go.mod file updating Go version; no test files present so Ginkgo test code quality check not applicable.
Microshift Test Compatibility ✅ Passed PR only updates Go version in go.mod; repository is a must-gather tool without test files, so MicroShift test compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR only updates Go version in go.mod; no new Ginkgo e2e tests are added, so the SNO compatibility check does not apply.
Topology-Aware Scheduling Compatibility ✅ Passed PR only modifies Go version in go.mod; does not change deployment manifests, operator code, controllers, or scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The OTE Binary Stdout Contract does not apply to OADP Must-gather, a standalone diagnostic tool that collects cluster information, not an OpenShift Tests Extension binary.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo e2e tests added; only Go version updated in go.mod from 1.25.0 to 1.25.8.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci

openshift-ci Bot commented Apr 17, 2026

Copy link
Copy Markdown

@weshayutin: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kaovilai

Copy link
Copy Markdown
Member

/close noop. these are managed by rebasebot PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants