Skip to content

set skip-tls default to true#71

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:oadp-devfrom
weshayutin:skip-tls
Sep 25, 2025
Merged

set skip-tls default to true#71
openshift-merge-bot[bot] merged 2 commits into
openshift:oadp-devfrom
weshayutin:skip-tls

Conversation

@weshayutin

Copy link
Copy Markdown
Contributor
  • users are not reading the instructions to skip-tls
  • support /eng ends up w/ must-gather's that do not contain all the required logs

TODO: incorporate auto discovery of certs per bsl
velero-io/velero#8557

* users are not reading the instructions to skip-tls
* support /eng ends up w/ must-gather's that do not
contain all the required logs

TODO: incorporate auto discovery of certs per bsl
velero-io/velero#8557

Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
@openshift-ci openshift-ci Bot requested review from kaovilai and mpryc September 25, 2025 17:11
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2025
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2025

@shubham-pampattiwar shubham-pampattiwar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented Sep 25, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, shubham-pampattiwar, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [kaovilai,shubham-pampattiwar,weshayutin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Sep 25, 2025

Copy link
Copy Markdown

@weshayutin: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 5ce8bb8 into openshift:oadp-dev Sep 25, 2025
4 checks passed
@weshayutin

Copy link
Copy Markdown
Contributor Author

/cherry-pick oadp-1.5

@openshift-cherrypick-robot

Copy link
Copy Markdown
Contributor

@weshayutin: new pull request created: #72

Details

In response to this:

/cherry-pick oadp-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@PrasadJoshi12

PrasadJoshi12 commented Sep 26, 2025

Copy link
Copy Markdown

@weshayutin @kaovilai @shubham-pampattiwar This will skip TLS verification for AWS, GCP and Azure bucket as well, right ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants