OU-1269: Update monitoring-console-plugin for 4.22#923
Conversation
|
@PeterYurkovich: This pull request references OU-1269 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PeterYurkovich The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/cherry-pick release-coo-ocp-4.22 |
|
@PeterYurkovich: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughDocs and deploy script edits; large, consistent refactor replacing default React imports/types with named imports and an ESLint prohibition; Perses dashboard dialogs rewritten to react-hook-form + Zod with shared helpers; assorted type-only tweaks, minor UI column removal, datasource/CSRF behavior tweaks, and a new data-test id. ChangesReact import & linting standardization
Perses dashboards — dialogs, helpers & validation (feature + behavioral)
Alerting, Incidents & test IDs
Datasource & CSRF helper tweaks
Docs, locales, and deployment
Sequence Diagram(s)sequenceDiagram
participant User as rgba(10,120,200,0.5) User
participant UI as rgba(0,150,136,0.5) UI (React)
participant Perses as rgba(255,193,7,0.5) Perses API
participant Backend as rgba(156,39,176,0.5) Backend API
participant Toast as rgba(244,67,54,0.5) Toasts
User->>UI: Open Create/Import dialog
UI->>UI: Render PermissionStateWrapper + react-hook-form
UI->>Perses: load editable projects (useDashboardProjects)
Perses-->>UI: projects list
User->>UI: Submit form
UI->>UI: ensureProjectExists(project) via useProjectCreation
UI->>Backend: create project (if missing)
Backend-->>UI: project created / error
UI->>Backend: migrate/import dashboard (useMigrateDashboard)
Backend-->>UI: import result
UI->>Toast: addAlert(success/error)
UI->>UI: navigateToDashboard(createdDashboard)
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 11 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (11 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
PeterYurkovich
force-pushed
the
update-mcp-with-fixes
branch
2 times, most recently
from
4bfdc6e to
952dfaa
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/deploy-acm.sh`:
- Around line 3-5: The script currently exports DOCKER_FILE_NAME and REPO but
they are unused and the call to make deploy does not enable ACM; either remove
those unused exports and add a short comment describing what make deploy does,
or modify the deployment to enable ACM by ensuring the helm install/upgrade
invoked by the make target sets plugin.features.acm.enabled=true and supplies
required ACM URLs; locate the make target named "deploy" (and any helm command
it runs) and add --set plugin.features.acm.enabled=true (and the ACM URL values)
or alternatively delete DOCKER_FILE_NAME/REPO and add a comment in
scripts/deploy-acm.sh describing that make deploy only sets plugin.image.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 28e4b566-cf93-42d9-a3a8-ccffc6b90f29
📒 Files selected for processing (43)
AGENTS.mdscripts/deploy-acm.shweb/cypress/CYPRESS_TESTING_GUIDE.mdweb/eslint.config.tsweb/locales/en/plugin__monitoring-plugin.jsonweb/src/components/Incidents/IncidentAlertStateIcon.tsxweb/src/components/Incidents/IncidentsChart/IncidentsChart.tsxweb/src/components/Incidents/IncidentsPage.tsxweb/src/components/Incidents/ToolbarItemFilter.tsxweb/src/components/Incidents/utils.tsweb/src/components/MetricsPage.tsxweb/src/components/TypeaheadSelect.tsxweb/src/components/alerting/AlertList/AggregateAlertTableRow.tsxweb/src/components/alerting/AlertList/LabelFilter.tsxweb/src/components/alerting/AlertsPage.tsxweb/src/components/console/utils/ref-width-hook.tsweb/src/components/console/utils/single-typeahead-dropdown.tsxweb/src/components/dashboards/perses/PersesWrapper.tsxweb/src/components/dashboards/perses/ToastProvider.tsxweb/src/components/dashboards/perses/dashboard-action-modals.tsxweb/src/components/dashboards/perses/dashboard-action-validations.tsweb/src/components/dashboards/perses/dashboard-actions-menu.tsxweb/src/components/dashboards/perses/dashboard-create-dialog.tsxweb/src/components/dashboards/perses/dashboard-dialog-helpers.tsxweb/src/components/dashboards/perses/dashboard-frame.tsxweb/src/components/dashboards/perses/dashboard-header.tsxweb/src/components/dashboards/perses/dashboard-import-dialog.tsxweb/src/components/dashboards/perses/dashboard-list-frame.tsxweb/src/components/dashboards/perses/dashboard-list.tsxweb/src/components/dashboards/perses/dashboard-page.tsxweb/src/components/dashboards/perses/datasource-api.tsweb/src/components/dashboards/perses/perses/datasource-cache-api.tsweb/src/components/dashboards/perses/project/ProjectDropdown.tsxweb/src/components/data-test.tsweb/src/components/ols-tool-ui/ShowTimeseries.tsxweb/src/components/ols-tool-ui/helpers/AddToDashboardButton.tsxweb/src/components/ols-tool-ui/helpers/OlsToolUIPersesWrapper.tsxweb/src/components/table/TableFilters.tsxweb/src/components/table/TableToolbar.tsxweb/src/components/table/useTableColumns.tsweb/src/components/table/useTablePagination.tsweb/src/components/targets-page.tsxweb/src/contexts/MonitoringContext.tsx
💤 Files with no reviewable changes (3)
- web/src/components/alerting/AlertList/AggregateAlertTableRow.tsx
- web/cypress/CYPRESS_TESTING_GUIDE.md
- AGENTS.md
✅ Files skipped from review due to trivial changes (24)
- web/src/components/ols-tool-ui/helpers/OlsToolUIPersesWrapper.tsx
- web/src/components/dashboards/perses/dashboard-list-frame.tsx
- web/src/components/Incidents/utils.ts
- web/src/components/dashboards/perses/ToastProvider.tsx
- web/src/components/targets-page.tsx
- web/src/components/console/utils/ref-width-hook.ts
- web/src/components/table/TableToolbar.tsx
- web/src/components/ols-tool-ui/ShowTimeseries.tsx
- web/src/components/ols-tool-ui/helpers/AddToDashboardButton.tsx
- web/src/components/dashboards/perses/dashboard-actions-menu.tsx
- web/eslint.config.ts
- web/src/components/dashboards/perses/dashboard-list.tsx
- web/src/components/dashboards/perses/dashboard-page.tsx
- web/src/components/table/useTableColumns.ts
- web/src/components/Incidents/IncidentsPage.tsx
- web/src/components/table/TableFilters.tsx
- web/src/components/dashboards/perses/PersesWrapper.tsx
- web/src/components/table/useTablePagination.ts
- web/src/components/dashboards/perses/dashboard-header.tsx
- web/src/components/dashboards/perses/project/ProjectDropdown.tsx
- web/src/components/Incidents/IncidentsChart/IncidentsChart.tsx
- web/src/components/TypeaheadSelect.tsx
- web/src/contexts/MonitoringContext.tsx
- web/src/components/MetricsPage.tsx
🚧 Files skipped from review as they are similar to previous changes (14)
- web/src/components/data-test.ts
- web/src/components/alerting/AlertList/LabelFilter.tsx
- web/src/components/Incidents/ToolbarItemFilter.tsx
- web/src/components/dashboards/perses/dashboard-frame.tsx
- web/src/components/alerting/AlertsPage.tsx
- web/src/components/Incidents/IncidentAlertStateIcon.tsx
- web/src/components/dashboards/perses/dashboard-dialog-helpers.tsx
- web/src/components/dashboards/perses/dashboard-create-dialog.tsx
- web/src/components/dashboards/perses/dashboard-action-validations.ts
- web/src/components/dashboards/perses/datasource-api.ts
- web/src/components/dashboards/perses/dashboard-import-dialog.tsx
- web/locales/en/plugin__monitoring-plugin.json
- web/src/components/dashboards/perses/dashboard-action-modals.tsx
- web/src/components/console/utils/single-typeahead-dropdown.tsx
|
/test e2e-aws-ovn |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Makefile`:
- Line 85: The recipe line for the deploy-acm target is indented with spaces
which triggers "missing separator"; replace the leading spaces before the
command "PUSH=1 REPO=monitoring-console-plugin
DOCKER_FILE_NAME=Dockerfile.dev-mcp scripts/build-image.sh" with a single tab
character so the Makefile recipe uses a tab indentation as required by GNU Make.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: c349161b-96f3-4113-bd8f-32b44df0fa1c
📒 Files selected for processing (2)
Makefilescripts/deploy-acm.sh
💤 Files with no reviewable changes (1)
- scripts/deploy-acm.sh
PeterYurkovich
force-pushed
the
update-mcp-with-fixes
branch
from
98b306f to
45e4a96
Compare
openshift-ci
Bot
added
the
needs-rebase
PeterYurkovich
force-pushed
the
update-mcp-with-fixes
branch
from
f027ed7 to
e937886
Compare
openshift-ci
Bot
removed
the
needs-rebase
|
@PeterYurkovich: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherry-pick release-4.22 |
|
@PeterYurkovich: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/label qe-approve |
|
@etmurasaki: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/label qe-approved |
openshift-ci
Bot
added
the
qe-approved
5 participants
This PR looks to update the monitoring-console-plugin pages for 4.22. It incorporates changes from the release-coo-0.5 branch as well as some other fixes from the new DataView usage. It finalized the removal of importing namespace scope React and adds a lint rule to prevent its usage in the future
Summary by CodeRabbit
Bug Fixes
New Features
Refactor
Documentation
Chores