AGENT-1531: Remove localhost.localdomain workaround for MCN IRI image field

[andfasano]

- What I did
The MCN CEL validation rule now accepts plain 'localhost' as a valid host (openshift/api#2800), so the sanitizeImagePullspec() workaround that converted localhost to localhost.localdomain is no longer needed.

- How to verify it
The iso-no-registry job must pass

Summary by CodeRabbit

• Bug Fixes
  • Corrected internal release image reference resolution to use localhost instead of localhost.localdomain, ensuring proper image registry connectivity for internal releases.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@andfasano: This pull request references AGENT-1531 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

- What I did
The MCN CEL validation rule now accepts plain 'localhost' as a valid host (openshift/api#2800), so the sanitizeImagePullspec() workaround that converted localhost to localhost.localdomain is no longer needed.

- How to verify it
The iso-no-registry job must pass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[andfasano]

/test e2e-agent-compact-ipv4-iso-no-registry

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 08ea122d-3435-4656-8879-d0c72b913a3f

📥 Commits

Reviewing files that changed from the base of the PR and between 29cbc3e and 0f0da9b.

📒 Files selected for processing (4)

• pkg/controller/internalreleaseimage/aggregation.go
• pkg/controller/internalreleaseimage/internalreleaseimage_controller_test.go
• pkg/daemon/internalreleaseimage/internalreleaseimage_manager.go
• pkg/daemon/internalreleaseimage/internalreleaseimage_manager_test.go

💤 Files with no reviewable changes (1)

• pkg/controller/internalreleaseimage/internalreleaseimage_controller_test.go

---

Walkthrough

This PR removes support for localhost.localdomain URLs and eliminates image pull spec sanitization. The contract for transformToAPIIntURL is narrowed in documentation and tests, the sanitizeImagePullspec helper is removed from the daemon manager, and test expectations are updated to reflect the localhost-only format.

Changes

Localhost URL Format and Image Sanitization Updates

Layer / File(s)	Summary
Transform API contract and test update pkg/controller/internalreleaseimage/aggregation.go, pkg/controller/internalreleaseimage/internalreleaseimage_controller_test.go	The transformToAPIIntURL function documentation is narrowed to describe only localhost support (removing localhost.localdomain), and the corresponding test case is updated to test localhost:22625/... transformation instead of localhost.localdomain:22625/....
Remove sanitization helper and update status/validation logic pkg/daemon/internalreleaseimage/internalreleaseimage_manager.go	The sanitizeImagePullspec helper method is removed. The refreshMachineConfigNodeStatus function now populates MachineConfigNodeStatusInternalReleaseImageRef.Image and calls CheckImageAvailability directly with unsanitized pull specs.
Update test assertions for new localhost format pkg/daemon/internalreleaseimage/internalreleaseimage_manager_test.go	Test expectations in the happy path and missing release manifest scenarios are updated from localhost.localdomain:22625/... to localhost:22625/....

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 11

❌ Failed checks (1 warning, 10 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Stable And Deterministic Test Names	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Test Structure And Quality	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Microshift Test Compatibility	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Single Node Openshift (Sno) Test Compatibility	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Topology-Aware Scheduling Compatibility	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Ote Binary Stdout Contract	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Ipv6 And Disconnected Network Test Compatibility	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
No-Weak-Crypto	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Container-Privileges	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
No-Sensitive-Data-In-Logs	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: removing the localhost.localdomain workaround from the MCN IRI image field handling across multiple files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

Tools execution failed with the following error:

Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error)

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[bfournie]

/retest-required

[bfournie]

/lgtm

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade
/test e2e-gcp-op-ocl-part1
/test e2e-gcp-op-ocl-part2
/test e2e-gcp-op-part1
/test e2e-gcp-op-part2
/test e2e-gcp-op-single-node
/test e2e-hypershift

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, bfournie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/controller/internalreleaseimage/OWNERS [andfasano,bfournie]
• pkg/daemon/internalreleaseimage/OWNERS [andfasano,bfournie]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[andfasano]

/verified by @andfasano

[openshift-ci-robot]

@andfasano: This PR has been marked as verified by @andfasano.

Details

In response to this:

/verified by @andfasano

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[andfasano]

/test e2e-gcp-op-ocl-part2

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD dc8e496 and 2 for PR HEAD 0f0da9b in total

[openshift-ci]

@andfasano: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.