CNF-23388: mockgen deprecated: use uber-go/mock instead#131
Open
sebrandon1 wants to merge 1 commit into
Open
Conversation
Karthik-K-N
reviewed
Nov 14, 2025
Member
Karthik-K-N
left a comment
Karthik-K-N
left a comment
There was a problem hiding this comment.
Thank you for the PR
Test failure is unrelated to this Platform
/lgtm
/approve
Member
|
/test okd-scos-e2e-aws-ovn |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Karthik-K-N, sebrandon1 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Member
|
/override okd-scos-e2e-aws-ovn |
Contributor
|
@Karthik-K-N: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Member
|
Since the failure is not related to the platform PowerVS /override ci/prow/okd-scos-e2e-aws-ovn |
Contributor
|
@Karthik-K-N: Overrode contexts on behalf of Karthik-K-N: ci/prow/okd-scos-e2e-aws-ovn DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
sebrandon1
force-pushed
the
mockgen_deprecation
branch
from
6251f1c to
236f8a5
Compare
Contributor
|
New changes are detected. LGTM label has been removed. |
Member
Author
|
/retest |
sebrandon1
force-pushed
the
mockgen_deprecation
branch
from
236f8a5 to
485f24f
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (293)
📒 Files selected for processing (7)
✅ Files skipped from review due to trivial changes (4)
WalkthroughThis PR migrates mock tooling and imports from github.com/golang/mock to go.uber.org/mock, updates go.mod dependency versions, updates go:generate directives and tools imports, and regenerates mock code (updated imports, an added isgomock field, and recorder parameters changed to any). ChangesMock migration cohort
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
sebrandon1
force-pushed
the
mockgen_deprecation
branch
from
485f24f to
a69b36f
Compare
sebrandon1
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@sebrandon1: This pull request references CNF-23388 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Member
Author
|
/retest |
sebrandon1
force-pushed
the
mockgen_deprecation
branch
from
a69b36f to
0b34353
Compare
sebrandon1
force-pushed
the
mockgen_deprecation
branch
from
0b34353 to
12116b0
Compare
Contributor
|
@sebrandon1: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/golang/mock is marked as archived as of
June 27, 2023. They recommend using go.uber.org/mock.This PR attempts to change the dependency to one that is maintained.
Tracking issue: redhat-best-practices-for-k8s/telco-bot#45
Summary by CodeRabbit
Chores
Refactor