-
Notifications
You must be signed in to change notification settings - Fork 666
[release-4.20] OCPBUGS-69732: Fix Helm chart installation with CA/TLS certificates #15862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-4.20
Are you sure you want to change the base?
Conversation
Console uses Kubernetes CRDs to manage Helm repositories, not Helm's repository cache. Setting chartPathOptions.RepoURL forced Helm to look for a cache that doesn't exist in the console pod's read-only filesystem. Remove RepoURL assignments and use direct URL downloads with CaFile, CertFile, and KeyFile for authentication. Fixes https://issues.redhat.com/browse/OCPBUGS-44235 Signed-off-by: Martin Szuc <mszuc@redhat.com>
Test that authentication setup does not set RepoURL and verify chart downloads work with CA/TLS certificates. Signed-off-by: Martin Szuc <mszuc@redhat.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-44235 has been cloned as Jira Issue OCPBUGS-69732. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-69732, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@martinszuc: This pull request references Jira Issue OCPBUGS-69732, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (pmacik@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: martinszuc, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@dperaza4dustbit Hello can you please approve this backport? Should I tag you to all intended backports? I would like to have this fix included in 4.19 and 4.18 as well |
This is an automated cherry-pick of #15607
/assign martinszuc