[release-4.22] OCPBUGS-92056: Stop setting DevPreviewNoUpgrade for TNF clusters#10516
Conversation
TNF clusters deployed via Agent-Based Install were unconditionally marked with DevPreviewNoUpgrade FeatureSet, blocking upgrades even on 4.22 where TNF is GA. Mirror the TNA pattern: set DevPreviewNoUpgrade only for 4.20 (minimum version), omit it for 4.22+ so the Default FeatureSet applies. Update getSupportLevel() to return DevPreview for 4.20 and Supported for later versions. Assisted-by: Claude Code <noreply@anthropic.com>
TNF is TechPreview in 4.20-4.21 and GA from 4.22, not DevPreview as
previously set. Use BaseVersionGreaterOrEqual("4.22") to cover both
TechPreview versions instead of BaseVersionEqual(minVersion).
Assisted-by: Claude Code <noreply@anthropic.com>
Assisted-by: Claude Code <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
Bot
added
the
size/M
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-91974 has been cloned as Jira Issue OCPBUGS-92056. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-92056, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/invalid-bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carbonin, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@fonta-rh: This pull request references Jira Issue OCPBUGS-92056, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified by fonta-rh |
openshift-ci-robot
added
the
verified
|
@fonta-rh: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/label backport-risk-assessed |
openshift-ci
Bot
added
the
backport-risk-assessed
openshift-merge-bot
Bot
merged commit 1090e09
into
openshift:release-4.22
|
@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-92056 Jira Issue OCPBUGS-92056 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| return err | ||
| } | ||
| if !isGA { | ||
| cfg.FeatureSet = configv1.TechPreviewNoUpgrade |
There was a problem hiding this comment.
Just FYI this has the (perhaps unexpected) side effect of turning on all Tech Preview features.
The alternative is to use CustomNoUpgrade and just enable the specific feature you need.
There was a problem hiding this comment.
Ahh, I copied this over from Two Nodes with Arbiter and didn't see the unintended effect.
I think it's not worth updating because this will only affect 4.21 and lower clusters, which no one is really going to install ever. Thanks for the warning though, I'll keep it in mind for the future
There was a problem hiding this comment.
Yeah, there is no point in changing this in the release-4.22 branch as by definition it is only used to install 4.22 🙂
But it is worth changing on master because that will affect clusters installed with the Assisted SaaS or MCE.
|
Fix included in release 4.22.0-0.nightly-2026-06-25-210812 |
7 participants
This is an automated cherry-pick of #10507
/assign fonta-rh