Skip to content

[release-ocm-2.15] MGMT-24571: Fix initrd PPI reboot loop by comparing correct image URL#10504

Open
openshift-cherrypick-robot wants to merge 1 commit into
openshift:release-ocm-2.15from
openshift-cherrypick-robot:cherry-pick-10456-to-release-ocm-2.15
Open

[release-ocm-2.15] MGMT-24571: Fix initrd PPI reboot loop by comparing correct image URL#10504
openshift-cherrypick-robot wants to merge 1 commit into
openshift:release-ocm-2.15from
openshift-cherrypick-robot:cherry-pick-10456-to-release-ocm-2.15

Conversation

@openshift-cherrypick-robot

Copy link
Copy Markdown

This is an automated cherry-pick of #10456

/assign carbonin

When a PreprovisioningImage uses InitRD format, the image-updated check
was always comparing the current ImageUrl against ISODownloadURL instead
of the InitrdURL. This caused the BMH to be rebooted on every reconcile
even when the initrd image had not changed.

Extract getExpectedImageURL to select the correct URL (ISO or initrd)
based on the PPI's AcceptFormats, and use it in the imageUpdated check.

Resolves https://redhat.atlassian.net/browse/MGMT-24571

Assisted-by: Claude Code <noreply@anthropic.com>
@openshift-ci-robot

openshift-ci-robot commented Jun 23, 2026

Copy link
Copy Markdown

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: MGMT-24571

Details

In response to this:

This is an automated cherry-pick of #10456

/assign carbonin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 23, 2026
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 99bf1609-bc1a-455a-be25-3133bc403d35

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested review from oourfali and rccrdpccl June 23, 2026 14:10
@openshift-ci

openshift-ci Bot commented Jun 23, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign gamli75 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 43.67%. Comparing base (7b69e76) to head (2feb1c2).

Files with missing lines Patch % Lines
...ler/controllers/preprovisioningimage_controller.go 87.50% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-ocm-2.15   #10504   +/-   ##
=================================================
  Coverage             43.66%   43.67%           
=================================================
  Files                   407      407           
  Lines                 70611    70618    +7     
=================================================
+ Hits                  30835    30843    +8     
  Misses                36997    36997           
+ Partials               2779     2778    -1     
Files with missing lines Coverage Δ
...ler/controllers/preprovisioningimage_controller.go 80.53% <87.50%> (+0.07%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-ci

openshift-ci Bot commented Jun 23, 2026

Copy link
Copy Markdown

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants