Skip to content

NO-ISSUE: [master] Bump OCP versions: 4.18, 4.22, 4.16, 4.20, 4.19, 4.21#10476

Closed
danmanor wants to merge 1 commit into
openshift:masterfrom
danmanor:bump/ocp-releases-07f7fa6d-d8a9-4bfd-b385-aa489b3115d4
Closed

NO-ISSUE: [master] Bump OCP versions: 4.18, 4.22, 4.16, 4.20, 4.19, 4.21#10476
danmanor wants to merge 1 commit into
openshift:masterfrom
danmanor:bump/ocp-releases-07f7fa6d-d8a9-4bfd-b385-aa489b3115d4

Conversation

@danmanor

@danmanor danmanor commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

OpenShift updates: 4.16.63 -> 4.16.64, 4.20.24 -> 4.20.25, 4.21.19 -> 4.21.20, 4.19.33 -> 4.19.34, 4.16.63-multi -> 4.16.64-multi, 4.19.33-multi -> 4.19.34-multi, 4.18.43-multi -> 4.18.44-multi, 4.22.0 -> 4.22.1, 4.22.0-multi -> 4.22.1-multi, 4.18.43 -> 4.18.44, 4.21.19-multi -> 4.21.20-multi, 4.20.24-multi -> 4.20.25-multi
RHCOS updates:

/test edge-e2e-metal-assisted-4-18 edge-e2e-metal-assisted-4-22 edge-e2e-metal-assisted-4-16 edge-e2e-metal-assisted-4-20 edge-e2e-metal-assisted-4-19 edge-e2e-metal-assisted-4-21
/cc @rccrdpccl @gamli75

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated OpenShift release images for versions 4.16 through 4.22 with the latest available patch releases
    • All supported architectures (x86_64, arm64) now configured with newest patches
    • OpenShift 4.22 set as the default release version

@openshift-ci-robot

Copy link
Copy Markdown

@danmanor: This pull request explicitly references no jira issue.

Details

In response to this:

OpenShift updates: 4.16.63 -> 4.16.64, 4.20.24 -> 4.20.25, 4.21.19 -> 4.21.20, 4.19.33 -> 4.19.34, 4.16.63-multi -> 4.16.64-multi, 4.19.33-multi -> 4.19.34-multi, 4.18.43-multi -> 4.18.44-multi, 4.22.0 -> 4.22.1, 4.22.0-multi -> 4.22.1-multi, 4.18.43 -> 4.18.44, 4.21.19-multi -> 4.21.20-multi, 4.20.24-multi -> 4.20.25-multi
RHCOS updates:

/test edge-e2e-metal-assisted-4-18 edge-e2e-metal-assisted-4-22 edge-e2e-metal-assisted-4-16 edge-e2e-metal-assisted-4-20 edge-e2e-metal-assisted-4-19 edge-e2e-metal-assisted-4-21
/cc @rccrdpccl @gamli75

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 18, 2026
@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6525fcb3-6b4a-409b-a069-06fe144534c0

📥 Commits

Reviewing files that changed from the base of the PR and between dc5aca5 and 316e97d.

📒 Files selected for processing (3)
  • data/default_release_images.json
  • deploy/podman/configmap.yml
  • openshift/template.yaml

Walkthrough

Image tags are bumped for OpenShift versions 4.16, 4.18, 4.19, 4.20, 4.21, and 4.22 across three files: data/default_release_images.json, deploy/podman/configmap.yml, and openshift/template.yaml. Each affected version's url and version fields advance by one patch increment for x86_64, arm64, and multi architectures.

Changes

OpenShift Release Image Tag Bumps

Layer / File(s) Summary
default_release_images.json tag bumps (4.16–4.22)
data/default_release_images.json
Updates url and version fields for six OpenShift versions (4.16.63→4.16.64, 4.18.43→4.18.44, 4.19.33→4.19.34, 4.20.24→4.20.25, 4.21.19→4.21.20, 4.22.0→4.22.1) across x86_64, arm64, and multi architecture entries.
Podman ConfigMap and OpenShift template updates
deploy/podman/configmap.yml, openshift/template.yaml
Replaces the embedded RELEASE_IMAGES JSON payload in both deployment artifacts with the updated image tags; the default marker moves to the 4.22.1 entry in the ConfigMap.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • openshift/assisted-service#10449: Updates the same three files with the previous 4.19 tag bump (4.19.32→4.19.33), directly preceding this PR's 4.19.33→4.19.34 change.
  • openshift/assisted-service#10472: Updates the same three files with the previous 4.21 tag bump (4.21.18→4.21.19), directly preceding this PR's 4.21.19→4.21.20 change.

Suggested labels

approved, size/S, lgtm

Suggested reviewers

  • gamli75
  • rccrdpccl

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error, 2 warnings)

Check name Status Explanation Resolution
Stable And Deterministic Test Names ❌ Error PR adds 9 Ginkgo test titles using fmt.Sprintf with dynamic variables (test.ctrlPlaneCount, test.expectedRole, test.role, test.status) or version constants that change test names, violating stable... Remove fmt.Sprintf from test titles in internal/bminventory/inventory_test.go (lines 715, 12149, 17899, 8063, 8164, 8191, 10867, 17149, 17169). Use static, descriptive test names instead; move dynamic values to test bodies/assertions only.
Description check ⚠️ Warning The description lacks the required structured template format, including issue checkboxes, environment impact selection, testing approach, and completion checklist that are specified in the repository's template. Reformat the description to follow the repository's template structure, including issue type checkboxes, environment impact checkboxes, testing method selection, and completion checklist items.
Test Structure And Quality ⚠️ Warning Test code in PR has 60+ bare Expect(err).NotTo(HaveOccurred()) assertions lacking meaningful messages required by check criterion 4. Tests should include descriptive failure messages. Add meaningful failure messages to assertions, e.g., Expect(err).NotTo(HaveOccurred(), "failed to load fencing credentials") instead of bare Expect(err).NotTo(HaveOccurred())
✅ Passed checks (12 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically identifies the main change: bumping OCP versions across six release channels (4.16, 4.18, 4.19, 4.20, 4.21, 4.22).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Microshift Test Compatibility ✅ Passed PR only updates OpenShift version configuration files (JSON/YAML); no new Ginkgo e2e tests are added, so MicroShift test compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No Ginkgo e2e tests are added in this PR. Changes are limited to OpenShift release image version updates in configuration files (data/default_release_images.json, deploy/podman/configmap.yml, opens...
Topology-Aware Scheduling Compatibility ✅ Passed PR only updates OpenShift version numbers in configuration data files; no deployment manifests, scheduling constraints, or operator code are introduced or modified.
Ote Binary Stdout Contract ✅ Passed PR contains only data/configuration file changes (JSON and YAML files with OpenShift version tags), no executable code modifications. OTE Binary Stdout Contract check applies only to code, not conf...
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR only modifies configuration files (JSON/YAML) containing OpenShift release image version updates. No new Ginkgo e2e tests are added, so the IPv6/disconnected network compatibility check is...
No-Weak-Crypto ✅ Passed PR contains only configuration file updates (version numbers and URLs in JSON/YAML); no weak crypto algorithms (MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB), custom crypto implementations, or non-cons...
Container-Privileges ✅ Passed PR only updates OCP image version tags in configuration files; no privileged container configurations (privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation) are intr...
No-Sensitive-Data-In-Logs ✅ Passed PR updates only configuration/template files with OpenShift version numbers and public container image URLs; no logging statements expose passwords, tokens, API keys, PII, session IDs, internal hos...
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from gamli75 and rccrdpccl June 18, 2026 04:13
@openshift-ci openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 18, 2026
@openshift-ci

openshift-ci Bot commented Jun 18, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2026
@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.33%. Comparing base (dc5aca5) to head (316e97d).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10476   +/-   ##
=======================================
  Coverage   44.33%   44.33%           
=======================================
  Files         420      420           
  Lines       73252    73252           
=======================================
  Hits        32476    32476           
  Misses      37840    37840           
  Partials     2936     2936           

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gamli75

gamli75 commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

/retest-required

@gamli75

gamli75 commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2026
@gamli75

gamli75 commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

/retest

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 5b0651e and 2 for PR HEAD 316e97d in total

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 7c10bff and 1 for PR HEAD 316e97d in total

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD b91c174 and 0 for PR HEAD 316e97d in total

@openshift-ci

openshift-ci Bot commented Jun 19, 2026

Copy link
Copy Markdown

@danmanor: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/edge-verify-generated-code 316e97d link true /test edge-verify-generated-code
ci/prow/verify-generated-code 316e97d link true /test verify-generated-code

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/hold

Revision 316e97d was retested 3 times: holding

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2026
@danmanor

Copy link
Copy Markdown
Contributor Author

Closing as duplicate of #10483

@danmanor danmanor closed this Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants