Skip to content

[release-ocm-2.17] MGMT-24571: Fix initrd PPI reboot loop by comparing correct image URL#10473

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:release-ocm-2.17from
openshift-cherrypick-robot:cherry-pick-10456-to-release-ocm-2.17
Jun 22, 2026
Merged

[release-ocm-2.17] MGMT-24571: Fix initrd PPI reboot loop by comparing correct image URL#10473
openshift-merge-bot[bot] merged 1 commit into
openshift:release-ocm-2.17from
openshift-cherrypick-robot:cherry-pick-10456-to-release-ocm-2.17

Conversation

@openshift-cherrypick-robot

Copy link
Copy Markdown

This is an automated cherry-pick of #10456

/assign carbonin

When a PreprovisioningImage uses InitRD format, the image-updated check
was always comparing the current ImageUrl against ISODownloadURL instead
of the InitrdURL. This caused the BMH to be rebooted on every reconcile
even when the initrd image had not changed.

Extract getExpectedImageURL to select the correct URL (ISO or initrd)
based on the PPI's AcceptFormats, and use it in the imageUpdated check.

Resolves https://redhat.atlassian.net/browse/MGMT-24571

Assisted-by: Claude Code <noreply@anthropic.com>
@openshift-ci-robot

openshift-ci-robot commented Jun 16, 2026

Copy link
Copy Markdown

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: MGMT-24571

Details

In response to this:

This is an automated cherry-pick of #10456

/assign carbonin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b294aab8-ef40-401b-af18-2aaecd0924d5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 16, 2026
@openshift-ci openshift-ci Bot requested review from danmanor and rccrdpccl June 16, 2026 18:32
@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 44.33%. Comparing base (5f78696) to head (0200ca2).
⚠️ Report is 2 commits behind head on release-ocm-2.17.

Files with missing lines Patch % Lines
...ler/controllers/preprovisioningimage_controller.go 87.50% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-ocm-2.17   #10473   +/-   ##
=================================================
  Coverage             44.33%   44.33%           
=================================================
  Files                   417      417           
  Lines                 72810    72817    +7     
=================================================
+ Hits                  32279    32283    +4     
- Misses                37612    37614    +2     
- Partials               2919     2920    +1     
Files with missing lines Coverage Δ
...ler/controllers/preprovisioningimage_controller.go 80.16% <87.50%> (+0.08%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gamli75

gamli75 commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

/override ci/prow/e2e-ai-operator-disconnected-capi ci/prow/e2e-ai-operator-ztp-capi

@openshift-ci

openshift-ci Bot commented Jun 17, 2026

Copy link
Copy Markdown

@gamli75: Overrode contexts on behalf of gamli75: ci/prow/e2e-ai-operator-disconnected-capi, ci/prow/e2e-ai-operator-ztp-capi

Details

In response to this:

/override ci/prow/e2e-ai-operator-disconnected-capi ci/prow/e2e-ai-operator-ztp-capi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Jun 17, 2026

Copy link
Copy Markdown

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ai-operator-ztp-capi 0200ca2 link true /test e2e-ai-operator-ztp-capi
ci/prow/e2e-ai-operator-disconnected-capi 0200ca2 link true /test e2e-ai-operator-disconnected-capi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gamli75

gamli75 commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 18, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 18, 2026

Copy link
Copy Markdown

@gamli75: This pull request references MGMT-24571 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@gamli75

gamli75 commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

/test subsystem-aws

@gamli75

gamli75 commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

/test e2e-ai-operator-ztp

@gamli75

gamli75 commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

/approve
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2026
@openshift-ci

openshift-ci Bot commented Jun 21, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gamli75, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2026
@gamli75

gamli75 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

/retest

@openshift-merge-bot openshift-merge-bot Bot merged commit cfe1576 into openshift:release-ocm-2.17 Jun 22, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants