AGENT-1529: Add ovnKubernetesConfig to install-config definition

[zaneb]

This allows this field to be specified in install config overrides.

Summary by CodeRabbit

• New Features
  • Added support for OVN Kubernetes networking in baremetal installer settings.
  • Users can now specify OVN Kubernetes parameters, including an IPv4 configuration block.
  • The baremetal networking configuration accepts an optional OVN Kubernetes configuration field for flexible setup.

[openshift-ci-robot]

@zaneb: This pull request references AGENT-1529 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

This allows this field to be specified in install config overrides.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 33c02211-c483-47a5-aa4f-f4a496aced51

📥 Commits

Reviewing files that changed from the base of the PR and between 2511442 and ca0ddcb.

📒 Files selected for processing (2)

• internal/installcfg/installcfg.go
• internal/provider/registry/registry_test.go

🚧 Files skipped from review as they are similar to previous changes (1)

• internal/installcfg/installcfg.go

---

Walkthrough

This PR extends the baremetal installer configuration with OVN Kubernetes network support by introducing two new configuration types (IPv4OVNKConfig and OVNKConfig) and integrating an optional OVNKubernetesConfig field into the InstallerConfigBaremetal networking schema.

Changes

OVN Configuration Schema Extension

Layer / File(s)	Summary
OVN config types and schema integration internal/installcfg/installcfg.go, internal/provider/registry/registry_test.go	New IPv4OVNKConfig struct with internalJoinSubnet and OVNKConfig with optional ipv4 are added; InstallerConfigBaremetal networking gains an optional OVNKubernetesConfig *OVNKConfig (ovnKubernetesConfig JSON tag). The test helper getInstallerConfigBaremetal() is updated to include the new field.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 13 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is incomplete and does not follow the required template. Essential sections like issue listing, environment impact, testing approach, and checklists are missing or not addressed.	Complete the PR description by filling out the template sections including issue type, environment impact, testing method, and relevant checklist items.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (13 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: adding ovnKubernetesConfig to the install-config definition, which aligns with the actual code additions in the changeset.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	All Ginkgo test names in the modified registry_test.go file are stable and deterministic with no dynamic content, fmt.Sprintf, variables, or generated identifiers.
Test Structure And Quality	✅ Passed	No new Ginkgo tests added. Test file shows good practices: proper BeforeEach/AfterEach hooks, no cluster operations, single responsibility principle.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests are added. Changes only modify configuration types and a test helper function, outside the scope of this check.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR does not add new Ginkgo e2e tests; only adds configuration types and modifies an existing test helper function. Custom check only applies when new Ginkgo tests are added.
Topology-Aware Scheduling Compatibility	✅ Passed	PR adds configuration type definitions (OVNKConfig, IPv4OVNKConfig) for install-config overrides, not deployment manifests, operators, or scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	PR adds only struct type definitions and fields—no process-level code (main, init, TestMain) or stdout writes (fmt.Print, klog, log). Type additions cannot violate OTE stdout contract.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo e2e tests (It(), Describe(), Context(), When()) are added in this PR. Changes are limited to configuration type definitions and test helper updates, making the check not applicable.
No-Weak-Crypto	✅ Passed	PR adds OVN Kubernetes configuration data structures. No weak crypto patterns, custom crypto implementations, or insecure secret comparisons detected in changed files.
Container-Privileges	✅ Passed	PR modifies only Go configuration struct definitions (installcfg.go and test file), not container/K8s manifests. No privileged settings detected.
No-Sensitive-Data-In-Logs	✅ Passed	PR adds OVNKConfig types containing only network subnet data (InternalJoinSubnet); no logging statements expose passwords, tokens, API keys, PII, or other sensitive data.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zaneb
Once this PR has been reviewed and has the lgtm label, please assign avishayt for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.33%. Comparing base (eeb25a6) to head (ca0ddcb).
⚠️ Report is 32 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #10430      +/-   ##
==========================================
+ Coverage   44.32%   44.33%   +0.01%     
==========================================
  Files         420      420              
  Lines       73056    73056              
==========================================
+ Hits        32381    32390       +9     
+ Misses      37740    37735       -5     
+ Partials     2935     2931       -4     

Files with missing lines	Coverage Δ
internal/installcfg/installcfg.go	0.00% <ø> (ø)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[zaneb]

/retest-required

[openshift-ci]

@zaneb: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[bfournie]

/lgtm