fix: stop managing NodeHealthCheck (webhook requires a remediator)#231
Open
tiraboschi wants to merge 1 commit into
Open
fix: stop managing NodeHealthCheck (webhook requires a remediator)#231tiraboschi wants to merge 1 commit into
tiraboschi wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
❌ Generated Files Verification Failed One or more generated files in this PR are out of sync:
Please regenerate the files locally and commit the changes. |
The NHC admission webhook (vnodehealthcheck.kb.io) requires either remediationTemplate or escalatingRemediations. After 57550c3 removed the SNR remediationTemplate for detection-only mode, the webhook rejects every apply, failing the asset on every reconciliation cycle. Since the NHC API does not support detection-only mode, stop managing NodeHealthCheck entirely. Users who want node health checking must configure their own NHC with their preferred remediator. - Remove node-health-check from assets/active/metadata.yaml - Delete assets/active/node-health/ - Add tombstone to clean up existing managed NHC resources - Update tests that referenced the removed asset Fixes: https://redhat.atlassian.net/browse/CNV-91410 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NHC admission webhook (vnodehealthcheck.kb.io) requires either remediationTemplate or escalatingRemediations. After 57550c3 removed the SNR remediationTemplate for detection-only mode, the webhook rejects every apply, failing the asset on every reconciliation cycle.
Since the NHC API does not support detection-only mode, stop managing NodeHealthCheck entirely. Users who want node health checking must configure their own NHC with their preferred remediator.
Fixes: https://redhat.atlassian.net/browse/CNV-91410