fix: prevent per-asset event deduplication by encoding asset identity in action field#230
Open
tiraboschi wants to merge 1 commit into
Open
fix: prevent per-asset event deduplication by encoding asset identity in action field#230tiraboschi wants to merge 1 commit into
tiraboschi wants to merge 1 commit into
Conversation
… in action field The Kubernetes events broadcaster deduplicates on (action, reason, regarding, related, ...). All per-asset events shared the same action (equal to reason) and the same regarding object (HCO), so only the last asset's event survived per reconciliation cycle. Encode the target asset's Kind/Namespace/Name into the action field so each asset produces a distinct dedup key while the reason field stays unchanged for kubectl filtering. Fixes: https://redhat.atlassian.net/browse/CNV-91395 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Kubernetes events broadcaster deduplicates on (action, reason, regarding, related, ...). All per-asset events shared the same action (equal to reason) and the same regarding object (HCO), so only the last asset's event survived per reconciliation cycle.
Encode the target asset's Kind/Namespace/Name into the action field so each asset produces a distinct dedup key while the reason field stays unchanged for kubectl filtering.
Fixes: https://redhat.atlassian.net/browse/CNV-91395