Moving ObjectBucketClaim creation to ODF folder#807
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jgato The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Warning Review limit reached
More reviews will be available in 32 minutes and 11 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more credits in the billing tab to continue. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughThis PR relocates the observability ObjectBucketClaim (OBC) resource from required ACM configuration to optional ODF internal storage, renames the resource from ChangesObjectBucketClaim Relocation and Renaming
Container Image Version Updates
🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@telco-hub/configuration/reference-crs/required/acm/thanosSecretPolicy.yaml`:
- Around line 30-31: The template lookups for bucket credentials use variables
$objBucket and $awsAccess referencing the resource name
"observability-object-bucket", but the OBC actually creates resources under
metadata.name "observability-ob" (and omits spec.secretName/spec.configMapName),
so the lookup fails; fix by either changing the lookup keys to
"observability-ob" (update the lookup calls that set $objBucket and $awsAccess)
or by updating the OBC manifest to set spec.secretName and spec.configMapName to
"observability-object-bucket" so names align and $objBucket.data.* /
$awsAccess.data.* resolve.
In `@telco-hub/configuration/reference-crs/required/gitops/addPluginsPolicy.yaml`:
- Around line 78-80: The imageset-config mirror entries don’t match the
initContainer image tags used in addPluginsPolicy.yaml; update
telco-hub/install/mirror-registry/imageset-config.yaml so its additionalImages
list includes the exact tags used by
telco-hub/configuration/reference-crs/required/gitops/addPluginsPolicy.yaml (add
registry.redhat.io/openshift4/ztp-site-generate-rhel8:v4.21 and
registry.redhat.io/rhacm2/multicluster-operators-subscription-rhel9:v2.16), or
alternatively change the image references in addPluginsPolicy.yaml to the
currently mirrored tags; ensure you edit the additionalImages block in
imageset-config.yaml and include the exact image strings to guarantee the
disconnected mirror contains those tags.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Enterprise
Run ID: a5fde133-8efa-404b-9f31-c2d46a7c2c32
📒 Files selected for processing (7)
telco-hub/configuration/reference-crs-kube-compare/metadata.yamltelco-hub/configuration/reference-crs-kube-compare/optional/odf-internal/observabilityOBC.yamltelco-hub/configuration/reference-crs/optional/odf-internal/kustomization.yamltelco-hub/configuration/reference-crs/optional/odf-internal/observabilityOBC.yamltelco-hub/configuration/reference-crs/required/acm/kustomization.yamltelco-hub/configuration/reference-crs/required/acm/thanosSecretPolicy.yamltelco-hub/configuration/reference-crs/required/gitops/addPluginsPolicy.yaml
💤 Files with no reviewable changes (1)
- telco-hub/configuration/reference-crs/required/acm/kustomization.yaml
OBC (ObjectBucketClaim) is a CR managed by ODF. So, unless we have installed ODF, the Manifest will never work. This makes Observability Policy to depend on existing CM and Secret with the S3 info. If you have ODF these are created by the OBC, if not the user needs to provide them. Otherwise we are making ACM dependent on ODF. Now, ACM depends on a CM/Secret.
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
2 participants
OBC (ObjectBucketClaim) is a CR managed by ODF. So, unless we have installed ODF, the Manifest will never work.
The OBC was created to configure Thanos for Observability (MCO) storage. As it is now, we are making ACM dependent on ODF. If ODF is not installed, the OBC creation, that is in the ACM folder, cannot be created and Observability will never work.
With this PR, we make Observability Policy, that configures Thanos storage, to depend on existing CM and Secret with the S3 info. If you have ODF, these are created by the OBC, if not the user needs to provide them.
Note: I have changed ztp-site-generate and acm to version of release-4.21, just for testing purpose. We have to fix this if we agree to merge