Remove extract-stats command#398
Merged
Merged
Conversation
KatieB5
approved these changes
May 13, 2026
There was a problem hiding this comment.
Looking at the old script, I was wondering if the .log files in tests/fixtures/metadata/old_style_logs could also be removed as part of this PR?
Maybe I've missed something but as far as I can tell, they were only used by the tests in tests/test_extract_stats.py, which is being removed in this PR.
Contributor
Author
There was a problem hiding this comment.
Thanks; I'd missed that! Actually we can remove all of the tests/fixtures/metadata now as they're only used in the extract-stats tests 🧹 — so I'll rebase this with that in a single commit.
Fixes #394. Reasoning: * It's already been deprecated a while. * It was only for use with `cohort-extractor` logs, and that has now been marked as unsupported since June 2025; reference: opensafely-core/cohort-extractor@bb89f63
StevenMaude
force-pushed
the
steve/remove-extract-stats
branch
from
8f90c8f to
1998ce3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #394.
Reasoning:
cohort-extractorlogs, and that has now been marked as unsupported since June 2025; reference: opensafely-core/cohort-extractor@bb89f63