Skip to content

change ambiguous activityId / campaignId / roomId#39

Merged
davidbmaier merged 2 commits into
openplanet-nl:mainfrom
ArEyeses79:activityId
Apr 6, 2026
Merged

change ambiguous activityId / campaignId / roomId#39
davidbmaier merged 2 commits into
openplanet-nl:mainfrom
ArEyeses79:activityId

Conversation

@ArEyeses79

Copy link
Copy Markdown
Contributor

The club activity request urls were previously using a notation where {activity type}Id was used to mean the activityId for an activity of that type, except for campaigns where campaignId did indeed mean the campaign's campaignId and not its activityId.
This was confusing since rooms used roomId to mean the room's activityId and not its roomId.

This pr changes the notation to use activityId whenever an activity ID is required, only leaving campaignId whenever a campaign ID is required.

@davidbmaier davidbmaier left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright, just a small nitpick.

Comment thread docs/live/club-management/create-ranking.md Outdated
Comment thread docs/live/club-management/create-ranking.md Outdated

@davidbmaier davidbmaier left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@davidbmaier davidbmaier merged commit e613f38 into openplanet-nl:main Apr 6, 2026
1 check passed
@ArEyeses79 ArEyeses79 deleted the activityId branch April 6, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants