Align Benchmark "select all" font and checkbox style with the rest of the checkboxes#2032
Align Benchmark "select all" font and checkbox style with the rest of the checkboxes#2032
Conversation
There was a problem hiding this comment.
Pull request overview
Updates SelectAllCheckbox styling defaults and usage to make the Benchmark “Select all” checkbox match the visual treatment of other checkboxes (OPS-3809).
Changes:
- Adjusted
SelectAllCheckboxCVA variants (including changing the default variant). - Updated Benchmark and Storybook usages to explicitly set
variant="primary"and normalize label font weight where needed.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/ui-components/src/ui/select-all-checkbox/select-all-checkbox.tsx | Tweaks variant styling and changes the component’s default variant. |
| packages/ui-components/src/stories/wizard/wizard.stories.tsx | Sets explicit variant="primary" and labelClassName="font-normal" on wizard “select all” examples. |
| packages/ui-components/src/stories/select-all-checkbox.stories.tsx | Sets explicit variant="primary" in the interactive story. |
| packages/react-ui/src/app/features/benchmark/components/dynamic-benchmark-step/multi-select-body.tsx | Sets explicit variant="primary" and label font normalization for Benchmark “select all”. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }, | ||
| defaultVariants: { | ||
| variant: 'primary', | ||
| variant: 'default', |
There was a problem hiding this comment.
Changing defaultVariants.variant from primary to default is a behavior/API change: any existing SelectAllCheckbox call sites that relied on the implicit primary styling will now render differently. There is at least one usage in the repo that does not pass variant (e.g. packages/react-ui/src/app/features/builder/block-properties/multi-select-block-property.tsx), so this PR will likely cause an unintended visual regression there unless that usage is updated or the default is kept as primary.
| variant: 'default', | |
| variant: 'primary', |
There was a problem hiding this comment.
This makes packages/react-ui/src/app/features/builder/block-properties/multi-select-block-property.tsx use default variant, this is ok, so it aligns with the styles before #1945.
|
Fixes OPS-3809.
Screenshots
Before:
After: