Use available panel space and scroll list options in benchmark wizard step#2031
Merged
Use available panel space and scroll list options in benchmark wizard step#2031
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request improves the benchmark wizard UI by implementing flexible layouts that utilize available panel space and enable scrolling for list options. The changes focus on making the wizard steps more responsive by applying flexbox patterns that allow content to properly fill and scroll within the allocated space.
Changes:
- Added flexbox layout classes to enable proper space utilization and scrolling behavior
- Introduced an optional
stepbodyClassNameprop to allow customization of the step body styling - Applied overflow and scroll classes to handle long lists of options
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/react-ui/src/app/features/benchmark/components/dynamic-benchmark-step/types.ts | Added optional stepbodyClassName prop to the component interface |
| packages/react-ui/src/app/features/benchmark/components/dynamic-benchmark-step/single-select-body.tsx | Added scrolling classes to SelectForm component |
| packages/react-ui/src/app/features/benchmark/components/dynamic-benchmark-step/multi-select-body.tsx | Restructured layout with flexbox classes and wrapper div for scrollable content |
| packages/react-ui/src/app/features/benchmark/components/dynamic-benchmark-step/dynamic-benchmark-step.tsx | Added flexbox classes to StepBody and threaded through the new prop |
| packages/react-ui/src/app/features/benchmark/components/benchmark-wizard.tsx | Updated WizardContent and WizardStep with flexbox classes and provided stepbodyClassName value |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...t-ui/src/app/features/benchmark/components/dynamic-benchmark-step/dynamic-benchmark-step.tsx
Outdated
Show resolved
Hide resolved
packages/react-ui/src/app/features/benchmark/components/dynamic-benchmark-step/types.ts
Outdated
Show resolved
Hide resolved
|
alexandrudanpop
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes OPS-3806.
Screenshots: