Remove step counter from benchmark wizard footer#2030
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the step counter UI from the benchmark wizard footer to avoid misleading/non-sequential progress when conditional steps are skipped (OPS-3805). Also cleans up the now-unused StepCounter UI component and its Storybook story from the shared UI components package.
Changes:
- Remove
StepCounterfrom the benchmark wizard footer UI. - Delete the
StepCountercomponent (and its exports) from@openops/components/ui. - Remove the related Storybook story and usage in the wizard story.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/ui-components/src/ui/step-counter/step-counter.tsx | Deletes the StepCounter component implementation. |
| packages/ui-components/src/ui/step-counter/index.ts | Removes the barrel export for StepCounter. |
| packages/ui-components/src/stories/wizard/wizard.stories.tsx | Removes StepCounter usage from the wizard footer example. |
| packages/ui-components/src/stories/wizard/step-counter.stories.tsx | Deletes the Storybook story for StepCounter. |
| packages/ui-components/src/index.ts | Removes the public export of ui/step-counter. |
| packages/react-ui/src/app/features/benchmark/components/benchmark-wizard-footer.tsx | Removes rendering of the step counter in the benchmark wizard footer. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes OPS-3805.
The benchmark wizard includes conditional steps (e.g., the account selection step for AWS, which is skipped when no accounts can be retrieved from the connection). When a step is skipped, the counter jumps non-sequentially — for example, from 2/5 to 4/5 — which is confusing and misleading to the user.