Web MapSDK by komplexon3 · Pull Request #909 · openmobilemaps/maps-core

komplexon3 · 2026-01-20T08:28:31Z

Initial version of the "Web MapSDK".

I added the patch from the exploration-repository and added checks to pick the correct shader version.
@matzf I marked bits that need to be looked at with TO_CHECK.

Note that the referenced djinni version is a feature branch. PR: UbiqueInnovation/djinni#28

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0cf9eb64e0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

web/src/FontManifestParser.cpp

web/src/FontLoader.cpp

komplexon3 · 2026-01-21T08:40:41Z

I forgot to make one change: I had to rename a parameter in the logger because it was a keyword in JS. I still have to make the corresponding change for iOS and Android

maerki

Also:

Merge Djinni
Remove Demos

maerki · 2026-01-30T07:20:58Z

android/src/main/cpp/graphics/objects/Quad2dInstancedOpenGl.cpp


    if (textureHolder != nullptr) {
        texturePointer = textureHolder->attachToGraphics();
+        // WEB_EXTRAS: generate mipmaps -- this is useful for sprites as icons can be


Kommentar kann man entfernen

ifdef EMSCRIPTEN

Nochmals besprochen; da das nur für die icons verwendet wird ist die mipmap ungefährlich. Wir lassen es jetzt doch mal drin und sehen ob das die performance auf android spürbar beeinflusst.

android/src/main/cpp/graphics/objects/Text2dInstancedOpenGl.cpp

android/src/main/cpp/graphics/shader/AlphaInstancedShaderOpenGl.cpp

shared/src/graphics/Renderer.cpp

shared/src/map/layers/tiled/vector/symbol/Tiled2dMapVectorSymbolObject.cpp

web/src/FontLoader.cpp

web/src/FontManifestParser.cpp

web/src/GlobalLoader.cpp

komplexon3 · 2026-01-30T09:57:47Z

line aliasing in a separate PR

web/src/GlobalLoader.cpp

komplexon3 · 2026-01-30T10:37:14Z

add build to ci

- rename GlobalLoader to WebLoader, implement loader interface directly in WebLoader - support request cancellation in WebLoader - cleanup ImageValTextureHolder

ImageValTextureHolder is implemented in C++ and needs +c djinni bindings so it can be passed through JS code.

matzf · 2026-02-02T16:25:35Z

Note: line anti-aliasing moved to #915.

Implementation was broken, does not seem necessary. Aside, fix includes for debug buld.

Went back and forth, but not changed intentionally in web map.

Exclude tessellation from build for web. Some functions used in the impelementation (glPatchParameteri) are not available in emscripten GL. We could work around this to make it compile anyway, but as tessellation is not supported in WebGL anyway there is no point.

…edOpenGl

Pull in latest changes from playground repo.

Only include what is necessary.

Was implicitly enabled previously by setting the texture parameters on the non-stretch variant. This could have led to inconsistent results, so explicitly enable it here also. This also makes it clearer that it would need to be _disabled_ if we don't want this here.

This ensures rebuild when globbed list changes; performance penality appears negligible and its a lot more convenient.

maerki · 2026-02-04T21:40:55Z

android/src/main/cpp/graphics/objects/Quad2dInstancedOpenGl.cpp

    // Bind the texture to this unit.
    glBindTexture(GL_TEXTURE_2D, (unsigned int)texturePointer);

+    // Enable mipmap min filtering


Nein, auch Android bzw. Java. Wir haben das nochmals mit @maurhofer-ubique besprochen; das wird nur für die icons gebraucht, drum sollte das ungefährlich sein. Den genauen performance impact auf Android werden wir dann mal anschauen.

komplexon3 requested a review from matzf January 20, 2026 08:28

chatgpt-codex-connector bot reviewed Jan 20, 2026

View reviewed changes

web/src/FontManifestParser.cpp Show resolved Hide resolved

web/src/FontLoader.cpp Outdated Show resolved Hide resolved

komplexon3 changed the title ~~code dump from exploration repository~~ Web MapSDK Jan 22, 2026

komplexon3 added 6 commits January 23, 2026 14:28

code dump from exploration repository

02fca87

add web demos

b54caa8

web - basic build

06b2fd7

different shader versions for web and general opengl

ab52cac

add web readme

c4f6305

fix ios build

1daef30

komplexon3 force-pushed the feature/web-map-sdk branch from 888f9c1 to 1daef30 Compare January 26, 2026 09:48

komplexon3 added 2 commits January 26, 2026 16:21

only generate "web-only" djinni bindings for wasm & ts

431aa05

fix android build

9944170

maerki requested changes Jan 30, 2026

View reviewed changes

komplexon3 commented Jan 30, 2026

View reviewed changes

web/src/GlobalLoader.cpp Outdated Show resolved Hide resolved

matzf added 4 commits February 2, 2026 09:22

Cancellation in web data loader, cleanup

1162d60

- rename GlobalLoader to WebLoader, implement loader interface directly in WebLoader - support request cancellation in WebLoader - cleanup ImageValTextureHolder

Generate +c bindings for texture holder for web ImageValTextureHolder

9c198b0

ImageValTextureHolder is implemented in C++ and needs +c djinni bindings so it can be passed through JS code.

Fix build instructions in web/readme

6970eb4

Revert Add Line anti-aliasing, move to separate change

17c0e5c

matzf added 8 commits February 2, 2026 17:27

Remove left-over djinni/yaml file for removed global_loader

bb36c46

Remove broken cache from web FontLoader

1215d4f

Implementation was broken, does not seem necessary. Aside, fix includes for debug buld.

Fix duplicate line merge error in Text2dInstancedOpenGl

5896ad8

Revert dubious optimisation of renderQueue in Renderer::drawFrame

4a6b801

Revert merge error in Tiled2dMapVectorSymbolObject

f2d0edb

Went back and forth, but not changed intentionally in web map.

Update djinni after merging feature branches for web

a434c7d

Ifdef EMSCRIPTEN for non-premultiplied-alpha in AlphaInstancedShader

b7c456c

Merge branch 'main' into feature/web-map-sdk

42aed8e

matzf added 4 commits February 4, 2026 13:45

Remove WEB_EXTRAS/TO_CHECK comment related to mipmap on Quad2dInstanc…

c8e82b4

…edOpenGl

Remove web/demos

79eac47

Cleanup and update web cmake build

ee6a9a8

Pull in latest changes from playground repo.

matzf force-pushed the feature/web-map-sdk branch from 4bd3293 to ee6a9a8 Compare February 4, 2026 12:45

matzf added 4 commits February 4, 2026 14:01

Cleanup emscripten opengl includes

689d009

Only include what is necessary.

Update golden image with tiny change on rotated symbols due to mipmap

f87b30e

Enable CONFIGURE_DEPENDS on all cmake GLOB's

51baf4d

This ensures rebuild when globbed list changes; performance penality appears negligible and its a lot more convenient.

matzf force-pushed the feature/web-map-sdk branch from 8a98fc2 to 51baf4d Compare February 4, 2026 14:41

github: add WASM build workflow

7f67dfc

matzf force-pushed the feature/web-map-sdk branch from 5ad798c to 7f67dfc Compare February 4, 2026 15:45

Update djinni reference to tagged 1.3.0 version

05fdb9c

matzf force-pushed the feature/web-map-sdk branch from fe326c2 to 05fdb9c Compare February 4, 2026 20:48

maerki approved these changes Feb 4, 2026

View reviewed changes

komplexon3 merged commit 4f837e0 into main Feb 5, 2026
7 checks passed

komplexon3 deleted the feature/web-map-sdk branch February 5, 2026 08:25

Conversation

komplexon3 commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

komplexon3 commented Jan 21, 2026

Uh oh!

maerki left a comment

Choose a reason for hiding this comment

Uh oh!

maerki Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

komplexon3 Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

matzf Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

komplexon3 commented Jan 30, 2026

Uh oh!

Uh oh!

komplexon3 commented Jan 30, 2026

Uh oh!

matzf commented Feb 2, 2026

Uh oh!

maerki Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

matzf Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

komplexon3 commented Jan 20, 2026 •

edited

Loading