fix(openemr-cmd): avoid SIGPIPE in worktree validation under pipefail

[kojiromike]

Summary

openemr-cmd worktree list and worktree remove can fail on setups with many git worktrees: list shows (no worktrees) even when entries exist, and remove aborts with Path '...' is not a registered git worktree.

Root cause

wt_validate_dir and wt_validate_dir_safe validate a path by piping git's worktree listing into grep:

git -C "${OPENEMR_ROOT}" worktree list --porcelain 2>/dev/null \
    | grep -Fqx "worktree ${dir_real}"

The script runs under set -o pipefail. grep -q exits as soon as it finds a match and closes the read end of the pipe. If git is still writing (its output exceeds the ~64KB pipe buffer, which happens once you have many worktrees), git receives SIGPIPE and exits 141. Under pipefail the pipeline's exit status becomes that 141, so the if ! branch fires and a path that is a registered worktree gets rejected.

This stays latent on typical setups where git's output fits in the pipe buffer and git finishes writing before grep exits — the SIGPIPE never happens.

Fix

Capture the listing into a variable first, then match with a herestring. No pipe means no SIGPIPE:

local worktrees
worktrees=$(git -C "${OPENEMR_ROOT}" worktree list --porcelain 2>/dev/null)
if ! grep -Fqx "worktree ${dir_real}" <<< "${worktrees}"; then
    ...
fi

Test plan

• shellcheck clean under the repo's .shellcheckrc (enable=all)
• bash -n passes
• Reproduced the failure on a machine with ~150 worktrees: the old pipe form fails under pipefail (pipeline exits 141); the herestring form returns 0
• End-to-end on macOS: worktree list shows the entry and worktree remove completes cleanly (both previously broken)

Note

Found while verifying #783 (the macOS realpath fix). That fix let execution finally reach this validation code, surfacing this separate, platform-independent bug. The two are independent; this PR stands alone.

[Copilot]

Pull request overview

This PR fixes a correctness issue in openemr-cmd worktree validation when running under set -o pipefail with many worktrees, by eliminating a git ... | grep -q pipeline that can trigger SIGPIPE and produce false negatives.

Changes:

• Replace git worktree list --porcelain | grep -Fqx ... with a “capture then grep via herestring” approach in wt_validate_dir and wt_validate_dir_safe.
• Add explanatory comments documenting the SIGPIPE/pipefail failure mode.
• Bump script version to 1.0.40.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.