fix(harvest): missing new (Geo)DCAT-AP mapping for dct:provenance and dct:*rights#3720
Merged
maudetes merged 1 commit intoopendatateam:mainfrom Apr 15, 2026
Conversation
…*rights dct:provenance and dct:*rights used to contain a rdfs:label, but the GeoDCAT-AP 3 spec mentions that dct:description can be used, and the SEMIC and GeoNetwork converters now use that spec. It is not clear where DCAT stands, and whether GeoDCAT-AP defines dct:description as a replacement or an addition to rdfs:label. Properties of dct:*Statements are not clearly defined so we can only rely on examples provided in the spec. So we add resolution of dct:description but keep rdfs:label as well. If an element contains both properties, we take the rdfs:label as the more likely "title" of the element. Even though the recent specs only give URI examples for licenses, we also apply the logic above to dct:license to preserve the already implemented coverage of free-text cases.
streino
changed the title
maudetes
approved these changes
Apr 15, 2026
|
|
||
|
|
||
| def serialize_value(value, parse_label=False): | ||
| def serialize_value(value, unwrap: list[URIRef] | None = None): |
Contributor
There was a problem hiding this comment.
I find the approach clean, nice 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix ecolabdata/ecospheres#1018
dct:provenanceanddct:*rightsused to contain ardfs:label, but the GeoDCAT-AP 3 spec mentions thatdct:descriptioncan be used (doc provenance, doc rights), and the SEMIC (main branch) and GeoNetwork converters now use that spec.It is not clear where DCAT stands, and whether GeoDCAT-AP defines
dct:descriptionas a replacement or an addition tordfs:label. Properties ofdct:*Statementsare not clearly defined so we can only rely on examples provided in the spec.So we add resolution of
dct:descriptionbut keeprdfs:labelas well. If an element contains both properties, we take therdfs:labelas the more likely "title" of the element.Even though the recent specs only give URI examples for licenses, we also apply the logic above to
dct:licenseto preserve the already implemented coverage of free-text cases.