Skip to content

cnn_3dobj: fix include and allow compilation of samples#871

Merged
opencv-pushbot merged 7 commits into
opencv:masterfrom
paroj:cnn_3dobj
Dec 7, 2016
Merged

cnn_3dobj: fix include and allow compilation of samples#871
opencv-pushbot merged 7 commits into
opencv:masterfrom
paroj:cnn_3dobj

Conversation

@paroj

@paroj paroj commented Nov 23, 2016

Copy link
Copy Markdown
Contributor

caffe/vision_layers.hpp is gone. also fix some warnings.

fixes #580

@sovrasov

Copy link
Copy Markdown
Contributor

@paroj please use resolves instead of fixes in the first comment (in this case the corresponding issue will be closed by buildbot when PR will be merged) and use WIP keyword if you are planning to add more commits into the PR.

@alalek

alalek commented Nov 30, 2016

Copy link
Copy Markdown
Member

resolves instead of fixes

Actually both are valid for GitHub: https://help.github.com/articles/closing-issues-via-commit-messages.
But please don't use this functionality in commits directly (PR description is the optimal way).

**WIP** in description doesn't run automatically any builds (this may be a problem because there is no access to rerun any builds). After remowing WIP you need to push new commits (or to amend previous commint and force push) to run automatic builds again.

@paroj

paroj commented Nov 30, 2016

Copy link
Copy Markdown
Contributor Author

@sovrasov this is not WIP. I just tend to add commits on existing PRs instead of opening new ones.

String mean_file = "no";
std::vector<String> ref_img;
String target_img = String(ts->get_data_path()) + "1_8.png";
String target_img = String(ts->get_data_path()) + "4_78.png";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have an error here:
could not read reference image /home/user/repositories/opencv_extra/testdata/cv/4_78.png

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently, you still have to set
export OPENCV_TEST_DATA_PATH=<opencv_contrib>/modules/cnn_3dobj/testdata

see: https://github.com/opencv/opencv_contrib/tree/master/modules/cnn_3dobj

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, lets wait for opencv/opencv#7750. It allows to add different testdata sources using ocv_add_testdata macro in CMake.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paroj Please apply these changes.
After that you can put OPENCV_TEST_DATA_PATH back to <opencv_extra>/testdata

@alalek

alalek commented Dec 2, 2016

Copy link
Copy Markdown
Member

Thank you! 👍

@opencv-pushbot opencv-pushbot merged commit a7ad78b into opencv:master Dec 7, 2016
opencv-pushbot pushed a commit that referenced this pull request Dec 7, 2016
@mshabunin

Copy link
Copy Markdown
Contributor

@paroj , can you please confirm whether we need changes from #453

@paroj paroj deleted the cnn_3dobj branch November 27, 2019 16:30
allnes pushed a commit to allnes/opencv_contrib that referenced this pull request Jun 9, 2024
allnes pushed a commit to allnes/opencv_contrib that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error on compiling: caffe/vision_layers.hpp: No such file or directory

5 participants