cnn_3dobj: fix include and allow compilation of samples#871
Conversation
|
@paroj please use resolves instead of fixes in the first comment (in this case the corresponding issue will be closed by buildbot when PR will be merged) and use WIP keyword if you are planning to add more commits into the PR. |
Actually both are valid for GitHub: https://help.github.com/articles/closing-issues-via-commit-messages.
|
|
@sovrasov this is not WIP. I just tend to add commits on existing PRs instead of opening new ones. |
| String mean_file = "no"; | ||
| std::vector<String> ref_img; | ||
| String target_img = String(ts->get_data_path()) + "1_8.png"; | ||
| String target_img = String(ts->get_data_path()) + "4_78.png"; |
There was a problem hiding this comment.
I have an error here:
could not read reference image /home/user/repositories/opencv_extra/testdata/cv/4_78.png
There was a problem hiding this comment.
currently, you still have to set
export OPENCV_TEST_DATA_PATH=<opencv_contrib>/modules/cnn_3dobj/testdata
see: https://github.com/opencv/opencv_contrib/tree/master/modules/cnn_3dobj
There was a problem hiding this comment.
Ok, lets wait for opencv/opencv#7750. It allows to add different testdata sources using ocv_add_testdata macro in CMake.
caffe/vision_layers.hpp is gone. also fix some warnings.
note that reference was merely regenerated, not verified.
|
Thank you! 👍 |
This reverts commit 02e75ff.
caffe/vision_layers.hpp is gone. also fix some warnings.
fixes #580