feat: add ability to get individual controller stats #53
+1,136
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambhav-jain-16
force-pushed
the
44
branch
2 times, most recently
from
f8a0dd5 to
7c07d8a
Compare
Author
|
Hi @kolyshkin |
Author
|
Hi @haircommander |
fs/fs.go
Outdated
| return stats, nil | ||
| } | ||
|
|
||
| func (m *Manager) GetCpuStats() (*cgroups.Stats, error) { |
Contributor
There was a problem hiding this comment.
maybe call these Add*Stats and have them take a stats object, so we can iteratively populate rather than needing to merge later
Author
There was a problem hiding this comment.
Makes sense.
I have refactored all to Add*Stats.
Contributor
|
would love to see some unit tests, and maybe even a POC of it being used in an end user project like CRI-O |
Author
I have added the unit tests
I'm not very familiar with codebase of CRI-O, but I can get a quick POC in |
sambhav-jain-16
force-pushed
the
44
branch
2 times, most recently
from
9a446c9 to
3bc182c
Compare
Contributor
|
LGTM thank you! |
Author
|
@haircommander metrics output |
Contributor
|
great thanks! cc @kolyshkin @AkihiroSuda @dims @dgrisonnet |
This adds methods to retrieve statistics for individual cgroup controllers (CPU, memory, pids, IO, hugetlb, rdma, misc) instead of requiring all stats to be fetched at once. This enables tools like cadvisor to collect specific metrics with different housekeeping intervals, reducing computational overhead. Fixes: opencontainers#44 Signed-off-by: Sambhav Jain <jnsmbhv@gmail.com>
AkihiroSuda
reviewed
Jan 6, 2026
|
|
||
| // AddMiscStats adds misc statistics to the provided stats object. | ||
| AddMiscStats(stats *Stats) error | ||
|
|
Member
There was a problem hiding this comment.
Maybe just add a single method like GetControllerStats(ControllerName) (*Stats, error)
Author
There was a problem hiding this comment.
In my opinion, it's better the current way of having clear API of each controller.
Specifying one function with controller name will result in messy switch case logic.
@haircommander wdyt?
Contributor
There was a problem hiding this comment.
I'm open to one function, but I do think it should be appending to the same structure so a caller doesn't have to merge them. WDYT about AddControllerStats(ControllerName, *Stats) error @AkihiroSuda
Contributor
There was a problem hiding this comment.
Perhaps we can have controller names as binary bits (or string[]) , so we can ask for any one or more controller statistics at once?
Something like
type StatsOptions struct {
// Controllers specifies which controllers to query.
// If nil or empty, all controllers are queried.
Controllers string[]
// Future options can be added here, e.g.
// Recursive bool
// ExcludePSI bool
// IncludeFoobar bool
}
type Manager interface {
...
// Stats returns cgroups statistics. Argument opts can be nil.
func (m Manager) Stats(opts *StatsOptions) (*cgroups.Stats, error)
// GetStats returns cgroups statistics.
//
// Deprecated: replace with [Stats](nil).
GetStats() (*Stats, error)
...
}Now, GetStats implementations can be as simple as return Stats(nil)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add methods to retrieve statistics for individual cgroup controllers
(CPU, memory, pids, IO, hugetlb, rdma, misc) instead of requiring all
stats to be fetched at once.
Fixes: #44