Add healthchecks and minor service improvements #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…YCLOAK_ADMIN_PASSWORD Use env vars KC_BOOTSTRAP_ADMIN_USERNAME and KC_BOOTSTRAP_ADMIN_PASSWORD respectively. BREAKING CHANGE: Rename environment variables KEYCLOAK_ADMIN to KC_BOOTSTRAP_ADMIN_USERNAME and KEYCLOAK_ADMIN_PASSWORD to KC_BOOTSTRAP_ADMIN_PASSWORD.
…consistency Follows the same naming convention as the official Keycloak environment variables, beginning with 'KC' prefix. BREAKING CHANGE: Rename environment variable KEYCLOAK_ADMIN to KC_DOMAIN.
When Docker is running in rootless mode DOCKER_SOCKET_PATH needs to be changed to "/run/user/1000/docker.sock".
When Keycloak container is restarted this line will produce an error in logs which is harmless, but unnecessary.
The `postgres` user is already defined in the [official image](https://github.com/docker-library/postgres/blob/39623ba5d20db58a25c3010896baaf54b9aa6b6d/17/alpine3.23/Dockerfile).
Added healthchecks for all services (`collabora` already had one): * `collaboration` * `keycloak` * `ldap-manager` * `ldap-server` * `opencloud` * `postgres` * `radicale` * `tika` * `traefik` Keycloak and Tika probes use `/dev/tcp/` to send a GET request because `curl` / `wget` are not available in the image. `opencloud` healthcheck could alternatively use `wget or `/dev/tcp` via `bash`; keeping all three approaches is unnecessary. Add frontend login-route healthcheck for `ldap-manager`, because the base image [dunglas/frankenphp:php8.4-alpine](https://github.com/php/frankenphp/blob/ddb11c1f72f5765d4eacae200ba5b1b8267b4dbe/Dockerfile) comes with backend-only healthcheck. NOTE: `/dev/tcp` is the leanest and least-bloated approach for healthchecking because it requires only a `bash` shell and no extra binaries, so it avoids increasing image size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added healthchecks for all services (
collaboraalready had one). Timing values for healthchecks may be adjusted.Other changes
postgresuser inpostgresservice).Breaking changes
Involves renaming the following environment variables: