Skip to content

Conversation

@openclouders
Copy link
Contributor

This PR updates the documentation.

@AlexAndBear AlexAndBear marked this pull request as ready for review January 29, 2026 10:37
Copilot AI review requested due to automatic review settings January 29, 2026 10:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates documentation files with revised timestamps and corrects environment variable descriptions and default values across the configuration documentation.

Changes:

  • Updated timestamp references from 2026-01-28 to 2026-01-29 in multiple documentation files
  • Revised environment variable descriptions for clarity and accuracy in global_configvars.md
  • Corrected default values for several configuration variables including cache database name, cache TTL, and max concurrency
  • Fixed ordering issues in the extended configuration variables documentation

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
docs/_static/env-vars/storage-users_configvars.md Updated timestamp from 2026-01-28-17-09-55 to 2026-01-29-10-34-56
docs/_static/env-vars/global_configvars.md Comprehensive updates to environment variable descriptions and default values across multiple configuration options
docs/_static/env-vars/frontend_configvars.md Updated timestamp from 2026-01-28-17-09-55 to 2026-01-29-10-34-56
docs/_static/env-vars/extended_configvars.md Fixed line ordering for MICRO_LOG_LEVEL and OC_GRPC_MAX_RECEIVED_MESSAGE_SIZE entries

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

`OC_LDAP_USER_SCHEMA_DISPLAYNAME` | 1.0.0 | string | LDAP Attribute to use for the display name of users. | displayName |
`OC_LDAP_USER_SCHEMA_ID` | 1.0.0 | string | LDAP Attribute to use as the unique ID for users. This should be a stable globally unique ID like a UUID. | openCloudUUID |
`OC_LDAP_USER_SCHEMA_ID_IS_OCTETSTRING` | 1.0.0 | bool | Set this to true if the defined 'ID' attribute for users is of the 'OCTETSTRING' syntax. This is required when using the 'objectGUID' attribute of Active Directory for the user ID's. | false |
`OC_LDAP_USER_SCHEMA_DISPLAYNAME` | 1.0.0 | string | LDAP Attribute to use for the displayname of users. | displayname |
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value 'displayname' appears inconsistent with the LDAP standard attribute 'displayName' (with capital 'N'). Verify this is intentional as LDAP attributes are case-sensitive.

Suggested change
`OC_LDAP_USER_SCHEMA_DISPLAYNAME` | 1.0.0 | string | LDAP Attribute to use for the displayname of users. | displayname |
`OC_LDAP_USER_SCHEMA_DISPLAYNAME` | 1.0.0 | string | LDAP Attribute to use for the displayname of users. | displayName |

Copilot uses AI. Check for mistakes.
`OC_LDAP_USER_SCHEMA_ID` | 1.0.0 | string | LDAP Attribute to use as the unique ID for users. This should be a stable globally unique ID like a UUID. | openCloudUUID |
`OC_LDAP_USER_SCHEMA_ID_IS_OCTETSTRING` | 1.0.0 | bool | Set this to true if the defined 'ID' attribute for users is of the 'OCTETSTRING' syntax. This is required when using the 'objectGUID' attribute of Active Directory for the user ID's. | false |
`OC_LDAP_USER_SCHEMA_DISPLAYNAME` | 1.0.0 | string | LDAP Attribute to use for the displayname of users. | displayname |
`OC_LDAP_USER_SCHEMA_ID` | 1.0.0 | string | LDAP Attribute to use as the unique id for users. This should be a stable globally unique id like a UUID. | openCloudUUID |
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent capitalization of 'id' - should be 'ID' to match the pattern used in line 56 ('id' attribute for groups) and for consistency with the variable name itself which uses 'ID'.

Suggested change
`OC_LDAP_USER_SCHEMA_ID` | 1.0.0 | string | LDAP Attribute to use as the unique id for users. This should be a stable globally unique id like a UUID. | openCloudUUID |
`OC_LDAP_USER_SCHEMA_ID` | 1.0.0 | string | LDAP Attribute to use as the unique ID for users. This should be a stable globally unique ID like a UUID. | openCloudUUID |

Copilot uses AI. Check for mistakes.
@AlexAndBear AlexAndBear merged commit 71d26a6 into main Jan 29, 2026
4 checks passed
@AlexAndBear AlexAndBear deleted the docs-update-0189acbb-e989-4a78-8279-16d5725434d5 branch January 29, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants