fix: align poll compatibility handling#248
Open
dovocoder wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
poll show --jsonso newer/unknown poll options do not disappear silentlyWhy
WhatsApp has multiple poll creation fields in the wire format. The existing whatsmeow convenience helper only emits the original/base field, while other clients already select newer fields depending on poll type. This PR keeps wacli aligned with those message variants so outbound polls remain compatible as WhatsApp clients continue to evolve.
This also makes poll result inspection more forward-compatible: if a synced vote references an option hash that wacli cannot currently map to a stored option, the hash is preserved and surfaced in JSON instead of being dropped.
Notes
BuildPollCreationhelper only builds the base poll field, but the generated proto exposes V2/V3 fields, so wacli now builds the minimal poll creation message locally and still sends throughSendMessage.Test Plan
git diff --check upstream/main...HEADgo test ./...pnpm test