Key controls for trial on windows and linux#544
Closed
Seeeeeyo wants to merge 2 commits into
Closed
Conversation
Introduced a new method to handle permanent delete shortcuts using Ctrl/Cmd + Backspace/Delete. Updated the delete handling logic to utilize this new method for improved clarity and functionality.
…pencap-viewer into trial_key_controls
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
There was a problem hiding this comment.
Pull request overview
This PR updates the trial-list keyboard shortcut handling in Session.vue to support a “permanent delete” modifier on Windows/Linux (Ctrl) in addition to macOS (Meta), aligning the delete behavior across platforms.
Changes:
- Introduces
isPermanentDeleteShortcut(event)to detect Delete/Backspace with Meta or Ctrl pressed. - Updates trial delete shortcut handling to use the new helper when choosing between “trash” vs “permanent delete” dialogs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.