Confirm neutral pose before processing#534
Open
keevindoherty wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR along with a companion on opencap-api opencap-org/opencap-api#302 adds a dialog box for the user to confirm a good neutral pose capture before processing.
Often it can happen that you're trying to record a neutral pose, but for one reason or another the recording goes poorly and you know it won't be useful for processing (e.g. the person you're recording moves, you accidentally start recording). Since neutral pose recordings are automatically processed, the user might have to wait several minutes to start again. Instead, this PR allows a user to just abort right away.
cc: @ashcollimore
Testing
I didn't go through mocking the full backend locally, so I couldn't test this very rigorously. If you have suggestions for me to test locally that you'd prefer me to implement before merging, let me know. The diff is pretty small though, so it might be easier to grab my changes and quickly run against a dev database if you have one set up?
Here's that dialog box in the viewer locally on my machine: