Skip to content

fix(ambient): default allow_bot_messages to true#1225

Merged
thepagent merged 2 commits into
mainfrom
fix/ambient-allow-bot-messages-default
Jun 27, 2026
Merged

fix(ambient): default allow_bot_messages to true#1225
thepagent merged 2 commits into
mainfrom
fix/ambient-allow-bot-messages-default

Conversation

@chaodu-agent

Copy link
Copy Markdown
Collaborator

Bot messages should be included in the ambient buffer by default so the agent has full channel context when deciding whether to reply. Users can opt out with allow_bot_messages = false if needed.

@chaodu-agent chaodu-agent requested a review from thepagent as a code owner June 27, 2026 23:20
@chaodu-agent

This comment has been minimized.

Bot messages should be included in the ambient buffer by default so the
agent has full channel context. Users can opt out with
allow_bot_messages = false if needed.
@chaodu-agent chaodu-agent force-pushed the fix/ambient-allow-bot-messages-default branch from 8b147a7 to 98be993 Compare June 27, 2026 23:22
@chaodu-agent

This comment has been minimized.

@thepagent thepagent merged commit 12d98c6 into main Jun 27, 2026
20 of 21 checks passed
@chaodu-agent

Copy link
Copy Markdown
Collaborator Author

LGTM ✅ — Clean default flip with consistent doc updates.

What This PR Does

Changes the default value of allow_bot_messages in AmbientDiscordConfig from false to true, so bot messages are included in the ambient buffer by default — giving agents full channel context without extra configuration.

How It Works

  • Removes the derive Default and implements Default manually to set allow_bot_messages: true
  • Uses the existing default_true() serde helper for deserialization consistency
  • Updates both docs/ambient.md and docs/config-reference.md to reflect the new default

Findings

# Severity Finding Location
1 🟢 Reuses existing default_true() helper — no unnecessary additions config.rs
2 🟢 Manual Default impl is minimal and correct config.rs:1337-1343
3 🟢 Documentation updated consistently across all references ambient.md, config-reference.md
Baseline Check
  • PR opened: 2026-06-27
  • Main already has: AmbientDiscordConfig with allow_bot_messages defaulting to false via derive Default
  • Net-new value: Flips the default to true so agents passively observe bot messages without opt-in config
What's Good (🟢)
  • Minimal diff — only touches what needs to change
  • Leverages existing default_true() helper at line 824, no code duplication
  • Both serde deserialization default and struct Default impl agree on the same value (true), preventing config inconsistencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants