MX-227: Use ANSI SQL in the Liquibase Scripts#103
Conversation
|
Caution Review failedThe pull request is closed. Warning
|
| Cohort / File(s) | Summary |
|---|---|
Database Migration - Conflict Handling Refactor src/main/resources/db/changelog/tenant/module/selfservice/parts/001-create-selfserviceuser-initial-schema.xml |
Replaced ON CONFLICT DO NOTHING with explicit AND NOT EXISTS duplicate detection in ss-0001-10 (user role mappings) and ss-0001-12 (self-service users). Added table aliases for source/destination qualification. Removed trailing ON CONFLICT clause from ss-0001-13. Changes improve cross-database compatibility while maintaining deduplication logic. |
Estimated code review effort
🎯 4 (Complex) | ⏱️ ~50 minutes
Poem
🐰 A migration most cunning and fine,
We banish conflicts, make logic align,
NOT EXISTS now guards each precious row,
No PostgreSQL tricks—just standards we know!
Portable schemas for all hops and springs, 🌱✨
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
Summary by CodeRabbit
Release Notes