Skip to content

feat(network): enable HTTP error validation in Ktor HttpClient #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
therajanmaurya wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

feat(network): enable HTTP error validation in Ktor HttpClient #122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core-base/network/src/commonMain/kotlin/template/core/base/network/KtorHttpClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,4 +159,8 @@ fun setupDefaultHttpClient(
install(ContentNegotiation) {
json(jsonConfig)
}

Copy link
Copy Markdown
Collaborator

@niyajali niyajali Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To prevent application crashes when the API fails for reasons such as network issues or server problems, we must implement client-side error handling, preferably by using a try-catch block or a custom interceptor or a sealed interface/class with custom errors data classes with serializable fields

// Enable response validation to throw exceptions for non-2xx responses
// This allows proper error handling with ClientRequestException (4xx) and ServerResponseException (5xx)
expectSuccess = true
}
Loading