Skip to content

Refactor string validation by removing redundant length check#197

Open
tiagosune wants to merge 1 commit intoopenMF:developfrom
tiagosune:refactor-string-empty-check
Open

Refactor string validation by removing redundant length check#197
tiagosune wants to merge 1 commit intoopenMF:developfrom
tiagosune:refactor-string-empty-check

Conversation

@tiagosune
Copy link
Copy Markdown

@tiagosune tiagosune commented Mar 25, 2026

Description

This PR simplifies string validation by removing redundant checks.

The previous condition used both length() != 0 and isEmpty(), which is unnecessary.
The updated version uses only !isEmpty(), improving readability and following best practices.

This change also aligns with SonarQube recommendations.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • [x ] Write the commit message as per our guidelines
  • [x ] Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • [x ] Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • [x ] This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant