Skip to content

drop 8.1 support, add 8.5#1857

Open
brettmc wants to merge 11 commits intoopen-telemetry:mainfrom
brettmc:add-85-drop-81
Open

drop 8.1 support, add 8.5#1857
brettmc wants to merge 11 commits intoopen-telemetry:mainfrom
brettmc:add-85-drop-81

Conversation

@brettmc
Copy link
Contributor

@brettmc brettmc commented Jan 17, 2026

Drop 8.1 support, and let rector upgrade the codebase with 8.2 as the minimum supported version

@brettmc brettmc requested a review from a team as a code owner January 17, 2026 09:21
@codecov
Copy link

codecov bot commented Jan 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.29%. Comparing base (26a2a4e) to head (a001e90).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1857      +/-   ##
============================================
- Coverage     68.34%   68.29%   -0.05%     
  Complexity     3009     3009              
============================================
  Files           449      449              
  Lines          8798     8798              
============================================
- Hits           6013     6009       -4     
- Misses         2785     2789       +4     
Flag Coverage Δ
8.2 68.26% <ø> (-0.02%) ⬇️
8.3 68.25% <ø> (-0.01%) ⬇️
8.4 68.25% <ø> (-0.02%) ⬇️
8.5 67.45% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26a2a4e...a001e90. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brettmc
Copy link
Contributor Author

brettmc commented Jan 20, 2026

NB that the upstream sury repo (which our developer image and shivammathur/setup-php use), doesn't have grpc yet, hence the two failures for 8.5

@cedricziel
Copy link
Contributor

@brettmc rector config can also be adjusted :)

@brettmc
Copy link
Contributor Author

brettmc commented Jan 21, 2026

rector config can also be adjusted :)

oh yeah, of course. That's an important missing step, thanks! :)

@brettmc brettmc changed the title drop 8.1 builds, add 8.5 drop 8.1 support, add 8.5 Jan 21, 2026
Copy link
Contributor

@Nevay Nevay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also update CONTRIBUTING.md and Makefile.

fail-fast: false
matrix:
php-version: ['8.1', '8.2', '8.3']
php-version: ['8.2', '8.3']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
php-version: ['8.2', '8.3']
php-version: ['8.2', '8.3', '8.4']

And remove 8.4 from include below. --ignore-platform-reqs should be no longer required, the 8.4 image contains ext-grpc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants