[Fix] explicitly disable weights_only in torch.load to fix tests #1650
Open
GaetanLepage wants to merge 1 commit intoopen-mmlab:mainfrom
Open
[Fix] explicitly disable weights_only in torch.load to fix tests #1650GaetanLepage wants to merge 1 commit intoopen-mmlab:mainfrom
GaetanLepage wants to merge 1 commit intoopen-mmlab:mainfrom
Conversation
8af5cb6 to
0b68e28
Compare
13 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Since pytorch v2.6.0, the
weights_onlyparameter oftorch.loaddefaults toTrue.This causes some failures in the
mmenginetest suite:We now need to explicitly disable
weights_onlywhen callingtorch.load.Modification
Add
weights_only=Falsetotorch.loadcalls where needed.BC-breaking (Optional)
No.
Use cases (Optional)
No.