Apply PR #36 review-thread fixes for config path, ClickHouse docs, and test cleanup#40
Draft
Copilot wants to merge 4 commits into
Draft
Apply PR #36 review-thread fixes for config path, ClickHouse docs, and test cleanup#40Copilot wants to merge 4 commits into
Copilot wants to merge 4 commits into
Conversation
…on snapshots Includes a small lifecycle fix in queryCompleted: archive on master Completed even when not all segments have reported. Without this, under load garbageCollect evicts queries from RunningQueriesStorage before the segment-timeout fires, so they never reach archChan and the CH sink stays empty for query_events / aggregated_metrics. Closes #34
Copilot
AI
changed the title
[WIP] Fix code based on review comments
Apply PR #36 review-thread fixes for config path, ClickHouse docs, and test cleanup
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the review-thread comments on PR #36 by fixing the default config-file resolution in
cmd/server, correcting ClickHouse schema-management documentation, and tightening a shared-state test. It also aligns theRenderTemplatedocstring with the actual missing-key behavior.Startup config path
app.Run(...)path.yagpcc.yamlwhen--config-pathis unset, instead of constructing/yagpcc.yaml.ClickHouse schema docs
--dump-onlyreference with the implemented CLI/config contract:--dump-schemaschema_management: dump_onlydump_onlylifecycle description to match actual behavior: the process exits after printing DDL; it does not continue starting the master.Template API comment accuracy
RenderTemplatecomments to state that missing keys fail with an error, matchingtemplate.Option("missingkey=error").Test isolation
internal/storage.CurrentTimewitht.Cleanup(...)inaggregated_storage_test.goso the package-global override cannot leak into later tests.