docs: ADR for updated disabled flag behaviour#1919
Conversation
✅ Deploy Preview for polite-licorice-3db33c ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dosubot
Bot
added
the
size:L
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces an Architecture Decision Record (ADR) to change flagd's handling of disabled flags. Instead of returning an error, disabled flags will now return a successful evaluation with a reason of DISABLED and the defaultVariant value, aligning with the OpenFeature specification. Feedback on the ADR highlights several technical implementation details that need to be addressed: the logic in evaluateVariant should be simplified, and the resolve[T] function must be updated to handle DISABLED reasons for empty variants to avoid type mismatch errors. Additionally, the proposal needs to account for gRPC v1 compatibility in bulk evaluations and include specific implementation steps in the timeline for the gRPC and OFREP service layers.
suthar26
force-pushed
the
docs/adr-disabled-flag-evaluation
branch
5 times, most recently
from
73a3398 to
c5259ee
Compare
suthar26
force-pushed
the
docs/adr-disabled-flag-evaluation
branch
from
c5259ee to
31200d1
Compare
toddbaert
changed the title
toddbaert
requested review from
alxckn,
askpt,
beeme1mr,
cupofcat,
erka and
juanparadox
There was a problem hiding this comment.
I think this is a bit of a blocker for me; it seems a bit incoherent. Maybe I'm missing something though or not thinking about it correctly. I think if this was changed this would be an easy approval for me. Please help me understand if I'm off-base 😅
suthar26
force-pushed
the
docs/adr-disabled-flag-evaluation
branch
3 times, most recently
from
9dcffbd to
a4f89fb
Compare
suthar26
force-pushed
the
docs/adr-disabled-flag-evaluation
branch
from
a4f89fb to
7b4902b
Compare
suthar26
force-pushed
the
docs/adr-disabled-flag-evaluation
branch
from
69abc6e to
ab05761
Compare
dosubot
Bot
added
size:M
There was a problem hiding this comment.
All my concerns, especially the one referenced here, have been addressed. I think this is a good idea, and recent improvements in OFREP and flagd make it more feasible than it once was.
I think this adds value to flagd as a solution, so I support it.
I would love consideration from more non-Dynatracers, particularly @cupofcat , @juanparadox , @askpt or others.
Maybe also @oxddr
Signed-off-by: Parth Suthar <parth.suthar@dynatrace.com>
Signed-off-by: Parth Suthar <parth.suthar@dynatrace.com>
Signed-off-by: Parth Suthar <parth.suthar@dynatrace.com>
- Clarify variant/value omission semantics across languages - Rename Timeline to Implementation steps grouped by phase - Add Versioning and migration section - Resolve open questions on dashboards, versioning, and FlagDisabledErrorCode removal - Fix MD029 ordered list numbering Signed-off-by: Parth Suthar <parth.suthar@dynatrace.com>
Signed-off-by: Parth Suthar <parth.suthar@dynatrace.com>
Signed-off-by: Parth Suthar <parth.suthar@dynatrace.com>
suthar26
force-pushed
the
docs/adr-disabled-flag-evaluation
branch
from
df03e2e to
00b2a72
Compare
|
|
I'd be happy to have a look, but I won't be able to do so earlier than next week. |
8 participants
This PR
Related Issues
Fixes #1918
Notes
Follow-up Tasks
How to test