feat: latest flagd#372
Merged
Merged
Conversation
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the FLAGD_BASE_IMAGE in the Dockerfile from version v0.15.0 to v0.15.5. Feedback indicates that v0.17.0 is the actual latest version and identifies a potential path error regarding the binary location that would cause the build to fail.
| @@ -1,4 +1,4 @@ | |||
| ARG FLAGD_BASE_IMAGE=ghcr.io/open-feature/flagd:v0.15.0 | |||
| ARG FLAGD_BASE_IMAGE=ghcr.io/open-feature/flagd:v0.15.5 | |||
There was a problem hiding this comment.
The PR title mentions 'latest flagd', but v0.15.5 is not the most recent version; v0.17.0 is currently available. Additionally, the official flagd image stores the binary at /flagd, but line 32 incorrectly references /flagd-build, which will cause the build to fail.
ARG FLAGD_BASE_IMAGE=ghcr.io/open-feature/flagd:v0.17.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See title.