RendezVous/Services: Fix incorrect Data vtable#7
Conversation
MonsterDruide1
left a comment
There was a problem hiding this comment.
@MonsterDruide1 reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on german77).
OnlineCore/include/Core/FileStorageDevice.h line 16 at r1 (raw file):
StorageUnit* Open(const String&); bool Close(StorageUnit*); bool Delete(const String&);
given that MemoryStorageDevice also extends StorageDevice and has the same functions, I'd argue they are virtual ... = 0; over there.
Suggestion:
StorageUnit* Create(const String&) override;
StorageUnit* Open(const String&) override;
bool Close(StorageUnit*) override;
bool Delete(const String&) override;
german77
left a comment
There was a problem hiding this comment.
@german77 made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on MonsterDruide1).
OnlineCore/include/Core/FileStorageDevice.h line 16 at r1 (raw file):
Previously, MonsterDruide1 wrote…
given that
MemoryStorageDevicealso extendsStorageDeviceand has the same functions, I'd argue they arevirtual ... = 0;over there.
Done.
Fixes mismatch due wrong vtable size.
This change is