Skip to content

RendezVous/Services: Fix incorrect Data vtable#7

Open
german77 wants to merge 2 commits into
open-ead:mainfrom
german77:vtable
Open

RendezVous/Services: Fix incorrect Data vtable#7
german77 wants to merge 2 commits into
open-ead:mainfrom
german77:vtable

Conversation

@german77

@german77 german77 commented May 25, 2026

Copy link
Copy Markdown
Contributor

Fixes mismatch due wrong vtable size.


This change is Reviewable

@MonsterDruide1 MonsterDruide1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MonsterDruide1 reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on german77).


OnlineCore/include/Core/FileStorageDevice.h line 16 at r1 (raw file):

    StorageUnit* Open(const String&);
    bool Close(StorageUnit*);
    bool Delete(const String&);

given that MemoryStorageDevice also extends StorageDevice and has the same functions, I'd argue they are virtual ... = 0; over there.

Suggestion:

    StorageUnit* Create(const String&) override;
    StorageUnit* Open(const String&) override;
    bool Close(StorageUnit*) override;
    bool Delete(const String&) override;

@german77 german77 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@german77 made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on MonsterDruide1).


OnlineCore/include/Core/FileStorageDevice.h line 16 at r1 (raw file):

Previously, MonsterDruide1 wrote…

given that MemoryStorageDevice also extends StorageDevice and has the same functions, I'd argue they are virtual ... = 0; over there.

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants