all: Enforce weak / global functions

OnlineCore/include/Core/StorageUnit.h

@@ -13,7 +13,9 @@ class StorageUnit {
     virtual void Truncate();
     virtual size_t Read(u64, u64, u8*) const;
     virtual size_t Write(u64, u64, u8*);
-    virtual bool Reserve(u64);
+
+    virtual bool Reserve(u64) { return false; }
+
     virtual u32 GetReservedSize();
 };
 }  // namespace nn::nex

OnlineCore/include/Platform/Core/Log.h

@@ -16,7 +16,8 @@ class Log : public RootObject {
     virtual ~Log();
     virtual void Output(const char*, ...);
     virtual void OutputString(const char*, ...);
-    virtual void AddCustomPrefix(char*, s32, void*);
+
+    virtual void AddCustomPrefix(char*, s32, void*) {}
 
     void OutputImpl(const char*, std::va_list, void*);
     void PrepareOutput(char*, u32, void*);

OnlineCore/include/Platform/Core/MemoryManager.h

@@ -20,8 +20,11 @@ class MemoryManager : public RootObject {
     MemoryManager(const char* watermarkName);
 
     virtual ~MemoryManager();
-    virtual void BeginProtection();
-    virtual void EndProtection();
+
+    virtual void BeginProtection() {}
+
+    virtual void EndProtection() {}
+
     static void* Allocate(u64);
     static void* GenericMalloc(u64);
     static void AllocateForPbPool(void*, fcnFree, void*);

OnlineCore/include/Platform/Core/OutputFormat.h

@@ -9,7 +9,7 @@ namespace nn::nex {
 class OutputFormat : public RootObject {
 public:
     OutputFormat();
-    virtual ~OutputFormat();
+    virtual ~OutputFormat() = default;
 
     virtual void StartString(char*, u32);
     virtual u32 StartPrefixes(char*, u32);

OnlineCore/src/Core/StorageUnit.cpp

@@ -30,10 +30,6 @@ bool StorageUnit::CopyData(const StorageUnit* source, StorageUnit* destination)
     return AppendData(source, destination);
 }
 
-bool StorageUnit::Reserve(u64) {
-    return false;
-}
-
 u32 StorageUnit::GetReservedSize() {
     return 0;
 }

OnlineCore/src/Platform/Core/Log.cpp

@@ -39,8 +39,6 @@ void Log::OutputString(const char* str, ...) {
     OutputImpl(str, va, nullptr);
 }
 
-void Log::AddCustomPrefix(char*, s32, void*) {}
-
 void Log::OutputImpl(const char* str, std::va_list va, void* ptr) {
     if (!m_LogDevice)
         return;

OnlineCore/src/Platform/Core/MemoryManager.cpp

@@ -74,8 +74,4 @@ const char* MemoryManager::GetInstructionTypeString(_InstructionType instruction
         return "UNDEFINED INSTRUCTION TYPE!";
 }
 
-void MemoryManager::BeginProtection() {}
-
-void MemoryManager::EndProtection() {}
-
 }  // namespace nn::nex

OnlineCore/src/Platform/Core/OutputFormat.cpp

@@ -11,8 +11,6 @@ OutputFormat::OutputFormat() {
     m_ulTime = Time::GetTime();
 }
 
-OutputFormat::~OutputFormat() {}
-
 void OutputFormat::StartString(char* str, u32) {
     *str = 0;
 }