Skip to content

Conversation

@AgnieszkaZaba
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Dec 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.76%. Comparing base (e8a464b) to head (617b755).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1773   +/-   ##
=======================================
  Coverage   86.76%   86.76%           
=======================================
  Files         414      414           
  Lines       10485    10485           
=======================================
  Hits         9097     9097           
  Misses       1388     1388           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@slayoo
Copy link
Member

slayoo commented Dec 21, 2025

@AgnieszkaZaba, this is super-useful!

enforce-notebook-run-order...............................................Failed
- hook id: enforce-notebook-run-order
- exit code: 1

❌ INVALID: examples/PySDM_examples/deJong_Azimi/box.ipynb
Error: Cells were not run sequentially. The cell that caused this error is #1 
and the previous cell was #1.

To fix this, restart the notebook kernel and run all cells sequentially.

❌ INVALID: examples/PySDM_examples/Lowe_et_al_2019/fig_2.ipynb
Error: Code cell was not run. The previous cell was #2.

To fix this, restart the notebook kernel and run all cells sequentially.

❌ INVALID: examples/PySDM_examples/Arabas_et_al_2025/fig_2.ipynb
Error: Cells were not run sequentially. The cell that caused this error is #8 
and the previous cell was #0.

To fix this, restart the notebook kernel and run all cells sequentially.

❌ INVALID: examples/PySDM_examples/Lowe_et_al_2019/fig_3.ipynb
Error: Cells were not run sequentially. The cell that caused this error is #5 
and the previous cell was #3.

To fix this, restart the notebook kernel and run all cells sequentially.

@slayoo
Copy link
Member

slayoo commented Dec 21, 2025

@AgnieszkaZaba
Copy link
Collaborator Author

@slayoo I don't know why we did not set it earlier. It was only in devops_tests!

@AgnieszkaZaba
Copy link
Collaborator Author

Before merging, I have to check all notebooks if they actually contain correct outputs (some of them are run with CI flag)

@AgnieszkaZaba AgnieszkaZaba changed the title add enforce-notebook-run-order pre-commit hook to config add enforce-notebook-run-order pre-commit hook to config; rerun notebooks Dec 21, 2025
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO Problem with rerunning - Values and plots are not correct

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO rerun again, contains warning

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO UserWarning: adaptive time-step reached dt_min
warnings.warn("adaptive time-step reached dt_min")

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO Needs rerun? Plots are different

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO S plot is not correct

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO S plot is not correct

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO no S plot

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outputs slightly different

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO plots are different!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously no plots - check if smoke test are passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants