-
Notifications
You must be signed in to change notification settings - Fork 49
add enforce-notebook-run-order pre-commit hook to config; rerun notebooks
#1773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1773 +/- ##
=======================================
Coverage 86.76% 86.76%
=======================================
Files 414 414
Lines 10485 10485
=======================================
Hits 9097 9097
Misses 1388 1388 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@AgnieszkaZaba, this is super-useful! |
|
just added analogous PRs to: |
|
@slayoo I don't know why we did not set it earlier. It was only in devops_tests! |
|
Before merging, I have to check all notebooks if they actually contain correct outputs (some of them are run with CI flag) |
enforce-notebook-run-order pre-commit hook to configenforce-notebook-run-order pre-commit hook to config; rerun notebooks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO Problem with rerunning - Values and plots are not correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO rerun again, contains warning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO UserWarning: adaptive time-step reached dt_min
warnings.warn("adaptive time-step reached dt_min")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO Needs rerun? Plots are different
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO S plot is not correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO S plot is not correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO no S plot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outputs slightly different
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO plots are different!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously no plots - check if smoke test are passing
No description provided.