Added Trig functions Sine, Cosine, Tan, Cotan, Secant, Cosecant, Arcsine, Arccosine, Arctan.#215
Open
DoggieGreg wants to merge 28 commits into
Open
Added Trig functions Sine, Cosine, Tan, Cotan, Secant, Cosecant, Arcsine, Arccosine, Arctan.#215DoggieGreg wants to merge 28 commits into
DoggieGreg wants to merge 28 commits into
Conversation
Merging new changes that fix featurs and changes how simplify work
made sin and cosine not regester properly
fucntions for tan
Finished unit circle test cases for sine
Author
|
Integrate not implemented and erroring |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds comprehensive support for additional trigonometric and inverse trigonometric functions to the symbolic math library. It introduces new expression classes for cosine, tangent, secant, cosecant, cotangent, and their respective inverses (arcsine, arccosine, arctan), and integrates them throughout the expression system, visitor interfaces, and serializers. The changes ensure these new functions are recognized, differentiated, simplified, and serialized properly.
New trigonometric and inverse trigonometric expression classes:
Added new classes:
Cosine,Tan,Secant,Cosecant,Cotan,Arcsine,Arccosine, andArctanin theOasisnamespace, each inheriting fromUnaryExpressionand supporting integration and expression type/category macros. [1] [2] [3] [4] [5] [6] [7] [8]Updated
include/CMakeLists.txtto install new header files for these classes. [1] [2]Integration into expression system:
ExpressionTypeenum to include all new trigonometric and inverse trigonometric types.FwdDecls.hpp. [1] [2]Sineclass to match the new template style and interface.Visitor and serialization support:
VisitorandTypedVisitorinterfaces to include visit methods for all new function types. [1] [2] [3]TypedVisitmethods inDifferentiateVisitor,SimplifyVisitor,InFixSerializer, andMathMLSerializerto handle the new expression types. [1] [2] [3] [4]These changes collectively make the library capable of representing, manipulating, and serializing a full suite of trigonometric and inverse trigonometric expressions.