feat: add ValidatePlaceholders for catalog entry service files#204
Merged
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrhillsman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
exe-prow-github-app
Bot
added
the
approved
mrhillsman
force-pushed
the
feat/validate-placeholders
branch
2 times, most recently
from
ee74afc to
7b9d67e
Compare
Extracts {{key}} placeholders from all service files via regex and
cross-references against declared param keys. Returns errors for
unknown placeholders (likely typos) and warnings for declared params
not referenced in any service file.
Signed-off-by: Melvin Hillsman <mhillsma@redhat.com>
mrhillsman
force-pushed
the
feat/validate-placeholders
branch
from
7b9d67e to
9036926
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ValidatePlaceholders(entry *CatalogEntry) ([]string, []string)tointernal/workloads/catalog.go{{key}}placeholders from all service files via regex and cross-references against declared param keys{{trhreads}}instead of{{threads}})catalog_test.go: all-match, typo error, unused param warning, mixed errors+warnings, no-paramsTest plan
ginkgo -v --focus "ValidatePlaceholders" ./internal/workloads/- all 5 tests passgo test ./...- full suite green, no regressionsResolves #201