Skip to content

Geoip heuristic#1074

Merged
LDiazN merged 15 commits intomasterfrom
geoip-heuristic
Feb 17, 2026
Merged

Geoip heuristic#1074
LDiazN merged 15 commits intomasterfrom
geoip-heuristic

Conversation

@LDiazN
Copy link
Contributor

@LDiazN LDiazN commented Feb 5, 2026

This PR implements the geoip mismatch heuristic for faulty measurement detection.

  • Event insertion is done with Clickhouse' asynchronous inserts, to prevent obstructing the main path to the fastpath
  • The table itself is defined to use that type of inserts by default
  • We use a short timeout for completing this query

Closes: #1073
See: #1070

@LDiazN LDiazN requested a review from hellais February 5, 2026 14:14
@LDiazN LDiazN self-assigned this Feb 5, 2026
Copy link
Contributor

@aagbsn aagbsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good, small suggestion to reuse ClickhouseDep

Copy link
Contributor

@aagbsn aagbsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes look good

@LDiazN LDiazN merged commit 9718dd9 into master Feb 17, 2026
7 checks passed
LDiazN added a commit that referenced this pull request Feb 17, 2026
Seems to be breaking prod
This reverts commit 9718dd9.
LDiazN added a commit that referenced this pull request Feb 17, 2026
Seems to be breaking prod
This reverts commit 9718dd9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Register geoip mismatches to clickhouse

2 participants