Skip to content

extend process spawn to allow allocating a tty, attaching #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rgarcia merged 8 commits into from
Dec 31, 2025
Merged

extend process spawn to allow allocating a tty, attaching #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f0f1f14
extend process spawn to allow allocating a tty, attaching
rgarcia Nov 11, 2025
7d69152
sensible hostname
rgarcia Nov 11, 2025
33e6f74
address bot comments
rgarcia Nov 11, 2025
b382d62
are you not entertained, cursor?
rgarcia Nov 11, 2025
55adbad
bugbot
rgarcia Nov 12, 2025
b4ff4e0
Merge branch 'main' into shell
Sayan- Nov 12, 2025
4f6272a
Merge origin/main into shell
rgarcia Dec 31, 2025
7d47214
Fix review feedback: buffered reader and uint16 overflow validation
rgarcia Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions images/chromium-headful/wrapper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,22 @@ if [[ -z "${WITHDOCKER:-}" ]]; then
disable_scale_to_zero
fi

# -----------------------------------------------------------------------------
# Ensure a sensible hostname ---------------------------------------------------
# -----------------------------------------------------------------------------
# Some environments boot with an empty or \"(none)\" hostname which shows up in
# prompts. Best-effort set a friendly hostname early so services inherit it.
if h=$(cat /proc/sys/kernel/hostname 2>/dev/null); then
if [ -z "$h" ] || [ "$h" = "(none)" ]; then
if command -v hostname >/dev/null 2>&1; then
hostname kernel-vm 2>/dev/null || true
fi
echo -n "kernel-vm" > /proc/sys/kernel/hostname 2>/dev/null || true
fi
fi
# Also export HOSTNAME so shells pick it up immediately.
export HOSTNAME="${HOSTNAME:-kernel-vm}"

# -----------------------------------------------------------------------------
# House-keeping for the unprivileged "kernel" user --------------------------------
# Some Chromium subsystems want to create files under $HOME (NSS cert DB, dconf
Expand Down
13 changes: 13 additions & 0 deletions images/chromium-headless/image/wrapper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,19 @@ if [[ -z "${WITHDOCKER:-}" ]]; then
disable_scale_to_zero
fi

# -----------------------------------------------------------------------------
# Ensure a sensible hostname ---------------------------------------------------
# -----------------------------------------------------------------------------
if h=$(cat /proc/sys/kernel/hostname 2>/dev/null); then
if [ -z "$h" ] || [ "$h" = "(none)" ]; then
if command -v hostname >/dev/null 2>&1; then
hostname kernel-vm 2>/dev/null || true
fi
echo -n "kernel-vm" > /proc/sys/kernel/hostname 2>/dev/null || true
fi
fi
export HOSTNAME="${HOSTNAME:-kernel-vm}"

# if CHROMIUM_FLAGS is not set, default to the flags used in playwright_stealth
if [ -z "${CHROMIUM_FLAGS:-}" ]; then
CHROMIUM_FLAGS="--accept-lang=en-US,en \
Expand Down
Loading
Loading