Skip to content

add back quotes for DISABLE_ADX flag#8365

Merged
j1010001 merged 1 commit into
masterfrom
jan/fix-build-disable-adx-flag
Jan 28, 2026
Merged

add back quotes for DISABLE_ADX flag#8365
j1010001 merged 1 commit into
masterfrom
jan/fix-build-disable-adx-flag

Conversation

@j1010001
Copy link
Copy Markdown
Member

@j1010001 j1010001 commented Jan 28, 2026

fixing removal of quotes in crypto_adx_flag.mk in #8355 - the build fails with:

unknown shorthand flag: '_' in -__BLST_PORTABLE__

port of: https://github.com/onflow/flow-go-internal/pull/7145

Summary by CodeRabbit

  • Chores
    • Refined build configuration for cryptographic library compilation flags to improve flag processing and propagation.

✏️ Tip: You can customize this high-level summary in your review settings.

@j1010001 j1010001 requested a review from a team as a code owner January 28, 2026 00:23
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 28, 2026

📝 Walkthrough

Walkthrough

A makefile change that wraps the DISABLE_ADX flag value in quotes, causing it to propagate as a quoted string into the CRYPTO_FLAG variable. This alters how CGO flags are formatted in the non-ADX build path while maintaining functional equivalence of the surrounding conditional logic.

Changes

Cohort / File(s) Summary
Makefile Configuration
crypto_adx_flag.mk
Wrapped DISABLE_ADX flags in quotes to convert the value from a plain token to a string literal, affecting how the value is substituted into CRYPTO_FLAG and consumed by CGO flags

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

A rabbit hops through makefiles old, 🐰
Adding quotes to flags so bold,
ADX disabled, strings now tight,
CGO flags wrapped just right!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding back quotes for the DISABLE_ADX flag in crypto_adx_flag.mk to fix a build failure.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Contributor

@tarakby tarakby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@j1010001 j1010001 added this pull request to the merge queue Jan 28, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jan 28, 2026
@j1010001 j1010001 added this pull request to the merge queue Jan 28, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jan 28, 2026
@j1010001 j1010001 merged commit c015122 into master Jan 28, 2026
61 checks passed
@j1010001 j1010001 deleted the jan/fix-build-disable-adx-flag branch January 28, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants