add back quotes for DISABLE_ADX flag#8365
Conversation
📝 WalkthroughWalkthroughA makefile change that wraps the DISABLE_ADX flag value in quotes, causing it to propagate as a quoted string into the CRYPTO_FLAG variable. This alters how CGO flags are formatted in the non-ADX build path while maintaining functional equivalence of the surrounding conditional logic. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
fixing removal of quotes in crypto_adx_flag.mk in #8355 - the build fails with:
port of: https://github.com/onflow/flow-go-internal/pull/7145
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.