This repository was archived by the owner on Mar 19, 2024. It is now read-only.
Build fixes from Feature/msz 0706f#17
Draft
miklosszegedi wants to merge 6 commits into
Draft
Conversation
added 5 commits
July 6, 2022 10:32
Author: Miklos Szegedi
Author: Miklos Szegedi
Author: Miklos Szegedi
Author: Miklos Szegedi
Author: Miklos Szegedi
Author
|
The goal of this pull request is to suggest some changes to make DPS CI finish successfully. |
peterargue
reviewed
Jul 6, 2022
Author: Miklos Szegedi Reviewer: Peter Argue
Author
|
The issue remaining is an undefined |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Fixes #
Checklist
Does the PR require tests to be added or updated?
This is the case if this PR updates currently unit tested code with new/removed paths, or if it adds new components
that should be tested.
Ideally PRs should include the tests to code they add, but if for some reason they do not, there should be a
TODOcomment in the place where the test should be, linking to a GitHub issue that details what test should be written.
Does the PR require documentation to be added or updated?
This is the case if this PR changes any of the following:
Misc