Fix/blog dark mode#1765
Merged
Merged
Conversation
|
@Muskankr is attempting to deploy a commit to the Om Roy's projects Team on Vercel. A member of the Team first needs to authorize it. |
Thanks for creating a PR for your Issue!
|
Owner
|
Conflict |
Muskankr
force-pushed
the
fix/blog-dark-mode
branch
from
809694d to
44684a9
Compare
Contributor
Author
|
@omroy07, Resolved |
Owner
|
not resolved |
Contributor
Author
|
@omroy07 resolved |
|
🎉 Congrats @Muskankr on getting your PR merged! 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The blogs section was not properly responding to dark mode theme changes. Theme styles were inconsistent and dark mode colors were not applied correctly across the page.
What changes are included in this PR?
data-themeAre these changes tested?
Yes. Tested manually by:
Are there any user-facing changes?
Yes. Users will now experience consistent and properly working dark mode styling in the blogs section.
Screenshots
Before
After
Thank you reviewing my PR!