Fix command injection in build workflow#4
Merged
Conversation
Untrusted values (workflow_dispatch input otp_version and the OTP-* git
tag name) were interpolated directly into shell run: blocks via ${{ ... }},
allowing arbitrary command execution.
- Pass untrusted/contextual values via env: and reference them as quoted
shell variables instead of inlining ${{ ... }} in run: scripts.
- Validate the resolved OTP version against a strict allowlist regex and
fail the job on anything outside [0-9.] with an optional -rcN suffix.
Applied across build-static, build-musl and build-glibc jobs.
wmnsk
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Untrusted values (workflow_dispatch input otp_version and the OTP-* git tag name) were interpolated directly into shell run: blocks via ${{ ... }}, allowing arbitrary command execution.
Applied across build-static, build-musl and build-glibc jobs.